Instead of silently parsing non-hex to an empty challenge, throw an error.
Also, add missing includes while touching the file.
test: Throw error when -signetchallenge is non-hex #27765
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2305-test-signetchallenge- changing 5 files +22 −23-
maflcko commented at 6:00 AM on May 26, 2023: member
-
test: Throw error when -signetchallenge is non-hex fa6b11a556
-
DrahtBot commented at 6:00 AM on May 26, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK TheCharlatan, kevkevinpal, kallewoof If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on May 26, 2023
- TheCharlatan approved
-
TheCharlatan commented at 9:18 AM on May 26, 2023: contributor
Nice, ACK fa6b11a55663e70369bfbbba5fccc55b33f2b310
-
kevkevinpal commented at 9:31 AM on May 26, 2023: contributor
ACK fa6b11a
- fanquake requested review from ajtowns on May 26, 2023
- fanquake requested review from kallewoof on May 26, 2023
-
kallewoof commented at 8:13 AM on May 29, 2023: member
ACK fa6b11a
- DrahtBot removed review request from kallewoof on May 29, 2023
- fanquake merged this on May 29, 2023
- fanquake closed this on May 29, 2023
- maflcko deleted the branch on May 29, 2023
- sidhujag referenced this in commit e69a42cd5c on May 29, 2023
- bitcoin locked this on May 28, 2024
