This PR aims to avoid intermittent network issues and speed up the "Win64 native [vs2022]" CI task by caching related to chocolately and vcpkg steps in the docker image cache.
ci: Use docker image cache for "Win64 native [vs2022]" task #27771
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:230528-docker-win changing 2 files +36 −32-
hebasto commented at 11:26 AM on May 28, 2023: member
- hebasto added the label Tests on May 28, 2023
-
DrahtBot commented at 11:26 AM on May 28, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sipsorcery If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- hebasto force-pushed on May 28, 2023
-
ci: Use docker image cache for "Win64 native [vs2022]" task 77551bc089
- hebasto force-pushed on May 28, 2023
- hebasto marked this as ready for review on May 28, 2023
-
hebasto commented at 8:28 AM on June 13, 2023: member
Friendly ping @MarcoFalke and @sipsorcery :)
-
maflcko commented at 8:57 AM on June 13, 2023: member
No objection to using the cache to avoid intermittent network issues. But the speedup was only ~2 minutes on a total runtime of 1 hour?
-
hebasto commented at 9:02 AM on June 13, 2023: member
No objection to using the cache to avoid intermittent network issues. But the speedup was only ~2 minutes on a total runtime of 1 hour?
You're right. I've added "avoid intermittent network issues" to the PR description.
-
sipsorcery commented at 10:37 AM on June 17, 2023: member
ACK 77551bc08976ca924096a008ed43efd9483376cc.
Seems like a good idea to me.
Won't the
ci/windows_test_imagefileimage be stored somewhere on the CI server for subsequent runs? I would have thought that would save more than 2 mins. -
maflcko commented at 10:43 AM on June 17, 2023: member
According to https://cirrus-ci.com/task/6075873112096768 the build took 5 min, so that is roughly the time you save. But with unit tests running for 10 min and functional tests for 40 min, it is saving not too much.
Avoiding intermittent network issues seems more useful.
-
hebasto commented at 4:15 PM on June 23, 2023: member
Won't the
ci/windows_test_imagefileimage be stored somewhere on the CI server for subsequent runs? I would have thought that would save more than 2 mins.Subsequent runs will use the cached image the same way as other jobs use the cached
ci/test_imageimage now. -
- hebasto closed this on Jul 27, 2023
- bitcoin locked this on Jul 26, 2024
Contributors
Labels