[25.x] build: disable boost multi index safe mode #27775

pull fanquake wants to merge 1 commits into bitcoin:25.x from fanquake:25_x_backport_27724 changing 4 files +5 −8
  1. fanquake commented at 4:15 pm on May 29, 2023: member
    Backports #27724 to 25.x.
  2. build: disable boost multi index safe mode
    Disable boost multi index safe mode by default when configuring with
    --enable-debug.
    
    This option can cause transactions to take a long time to be accepted
    into the mempool under certain conditions; iterator destruction takes
    O(n) time vs O(1) as they are stored in a singly linked list. See
    27586 for more information.
    
    Re-enable it on the CI builds which previously had it enabled.
    
    Re-enable it on the msan fuzz target so that we have fuzz tasks testing
    with it enabeld and disabled in this repo.
    
    Github-Pull: #27724
    Rebased-From: 59c89447499bd9d6202269879555b8bc37373aa2
    9dc5848492
  3. fanquake added this to the milestone 25.1 on May 29, 2023
  4. DrahtBot commented at 4:15 pm on May 29, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot added the label Backport on May 29, 2023
  6. fanquake requested review from stickies-v on Jun 1, 2023
  7. stickies-v approved
  8. stickies-v commented at 7:51 pm on June 1, 2023: contributor

    ACK 9dc584849

    Identical to the changes in 59c894474 (#27724), except two changes (1, 2) to the CI setup which I think can safely be ignored.

  9. fanquake merged this on Jun 2, 2023
  10. fanquake closed this on Jun 2, 2023

  11. fanquake deleted the branch on Jun 2, 2023
  12. bitcoin locked this on Jun 1, 2024


fanquake DrahtBot stickies-v

Labels
Backport

Milestone
25.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me