fuzz: fix wallet notifications.cpp #27786

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2023_fuzz_fix_wallet_notifications changing 1 files +4 −0
  1. furszy commented at 8:48 pm on May 30, 2023: member

    Fixing #27469 (comment).

    As the fuzzing test requires all blocks to be scanned by the wallet (because it is asserting the wallet balance at the end), we need to ensure that no blocks are skipped by the recently added wallet birth time functionality.

    This just means setting the chain accumulated time to the maximum value, so the wallet birth time is always below it, and the block is always processed by the wallet.

  2. fuzz: fix wallet notifications.cpp
    As the fuzzer test requires all blocks to be
    scanned by the wallet (because it is asserting
    the wallet balance at the end), we need to
    ensure that no blocks are skipped by the recently
    added wallet birth time functionality.
    
    This just means setting the chain accumulated time
    to the maximum value, so the wallet birth time is
    always below it, and the block is always processed.
    a10f032115
  3. DrahtBot commented at 8:48 pm on May 30, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on May 30, 2023
  5. DrahtBot added the label CI failed on May 30, 2023
  6. maflcko commented at 5:57 am on May 31, 2023: member
    lgtm ACK a10f032115644d60a4321af06768d87d625affc1, thanks
  7. fanquake merged this on May 31, 2023
  8. fanquake closed this on May 31, 2023

  9. sidhujag referenced this in commit 3802c64289 on May 31, 2023
  10. furszy deleted the branch on Feb 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me