Initialize database before checking changed txindex #2783

pull sipa wants to merge 1 commits into bitcoin:master from sipa:newtxindex changing 1 files +6 −6

sipa commented at 2:08 PM on June 22, 2013: member

In case no database exists yet, and -txindex(=1) is passed, we currently first check whether fTxIndex differs from -txindex (and ask the user to reindex in that case), and only afterwards initialize the database. By swapping these around (the initialization is a no-op in case the database already exists), we allow it to be born in txindex mode, without warning.

That also means we don't need to check -reindex anymore, as the wiping/reinit of the databases happens before checking.

Closes #2782.

Tested all 8 combinations of the database already existing or not, -reindex passed or not, -txindex set or not.

Initialize database before checking changed txindex

In case no database exists yet, and -txindex(=1) is passed, we currently first
check whether fTxIndex differs from -txindex (and ask the user to reindex in
that case), and only afterwards initialize the database. By swapping these
around (the initialization is a no-op in case the database already exists),
we allow it to be born in txindex mode, without warning.

That also means we don't need to check -reindex anymore, as the wiping/reinit
of the databases happens before checking.

067a6092ac

Diapolo commented at 4:14 PM on June 23, 2013: none

Yeah, seems like a better place for the check.
jgarzik commented at 7:48 PM on June 23, 2013: contributor

ACK
sipa referenced this in commit fd967fed89 on Jun 23, 2013
sipa merged this on Jun 23, 2013
sipa closed this on Jun 23, 2013
Bushstar referenced this in commit 12274e578a on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

sipa

Diapolo

jgarzik

Linked (view graph)

#2782 Initializing a new database with -txindex=1 set asks for reindex