Dump addresses every 15 minutes instead of 10 seconds #2789

pull sipa wants to merge 1 commits into bitcoin:master from sipa:overdump changing 2 files +6 −3

sipa commented at 10:24 PM on June 23, 2013: member

No description provided.
sipa commented at 10:28 PM on June 23, 2013: member

It used to be every 100s, but the thread refactor (presumably unintentionally) made it every 10s. I think every 15 minutes is more than enough.
jgarzik commented at 11:28 PM on June 23, 2013: contributor

ACK
gmaxwell commented at 11:35 PM on June 23, 2013: contributor

ACK.
laanwj commented at 7:40 AM on June 24, 2013: member

ACK Minor nit: maybe use a constant for the value instead of a direct magic number
Dump addresses every 15 minutes instead of 10 seconds c43da3f183
sipa commented at 9:49 AM on June 24, 2013: member

@laanwj Ok, introduced a DUMP_ADDRESSES_INTERVAL in net.cpp. @gmaxwell Made it sleep once before the first execution.
jgarzik commented at 1:52 PM on June 24, 2013: contributor

@sipa Where is the discussion for the sleep change? For a general facility, such as the one you are changing, it seems a valid use to directly begin execution.

Putting the sleep first strikes me as a hack-y approach to a problem, that does not belong in a generic facility. People in the Linux kernel routinely jigger sleep delays to paper over driver problems ;p
sipa commented at 1:54 PM on June 24, 2013: member

@jgarzik It's the only place where LoopForever is used. So yes, I'm changing its semantics, but I think both cases are meaningful, and only the one actually used is implemented.
jgarzik referenced this in commit 396485b14d on Jun 24, 2013
jgarzik merged this on Jun 24, 2013
jgarzik closed this on Jun 24, 2013
Bushstar referenced this in commit 0ed5ae05a5 on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors