fuzz: Fix implicit-integer-sign-change in wallet/fees fuzz target #27917

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2306-fuzz-fix- changing 1 files +1 −1
  1. maflcko commented at 10:10 am on June 20, 2023: member

    This fixes a bug in the fuzz target.

    0echo 'OiAAAPr//wAAAAAAAAA=' | base64  --decode > /tmp/a
    1UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" FUZZ=wallet_fees ./src/test/fuzz/fuzz  /tmp/a
    
    0wallet/fees.cpp:58:58: runtime error: implicit conversion from type 'unsigned int' of value 4294574080 (32-bit, unsigned) to type 'int' changed the value to -393216 (32-bit, signed)
    1    [#0](/bitcoin-bitcoin/0/) 0x5625ef46a094 in wallet::GetMinimumFeeRate(wallet::CWallet const&, wallet::CCoinControl const&, FeeCalculation*) src/wallet/fees.cpp:58:58
    2    [#1](/bitcoin-bitcoin/1/) 0x5625eedd467f in wallet::(anonymous namespace)::wallet_fees_fuzz_target(Span<unsigned char const>) src/wallet/test/fuzz/fees.cpp:64:11
    3...
    4
    5SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change wallet/fees.cpp:58:58 in 
    
  2. fuzz: Fix implicit-integer-sign-change in wallet/fees fuzz target faa05d1965
  3. DrahtBot commented at 10:11 am on June 20, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Jun 20, 2023
  5. dergoegge approved
  6. dergoegge commented at 10:52 am on June 20, 2023: member
    tACK faa05d1965b03d997c1814447d7772f3d43bcbdb
  7. DrahtBot added the label CI failed on Jun 20, 2023
  8. DrahtBot removed the label CI failed on Jun 20, 2023
  9. brunoerg approved
  10. brunoerg commented at 12:06 pm on June 20, 2023: contributor
    ACK faa05d1965b03d997c1814447d7772f3d43bcbdb
  11. fanquake merged this on Jun 20, 2023
  12. fanquake closed this on Jun 20, 2023

  13. maflcko deleted the branch on Jun 20, 2023
  14. sidhujag referenced this in commit 425bceb741 on Jun 21, 2023
  15. bitcoin locked this on Jun 19, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me