test: added coverage to estimatefee #27934

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:test/rpc/estimatefee/maxconf changing 1 files +3 −0
  1. kevkevinpal commented at 1:30 PM on June 22, 2023: contributor

    Added a assert for an rpc error when we try to estimate fee for the max conf_target

    Line I am adding coverage to https://github.com/bitcoin/bitcoin/blob/master/src/rpc/fees.cpp#LL71C52-L71C52

  2. test: added coverage to estimatefee
    Added a assert for an rpc error when we try to estimate fee for the max
    conf_target
    d05be124db
  3. DrahtBot commented at 1:30 PM on June 22, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Jun 22, 2023
  5. DrahtBot added the label CI failed on Sep 15, 2023
  6. achow101 requested review from josibake on Sep 20, 2023
  7. achow101 requested review from glozow on Sep 20, 2023
  8. DrahtBot removed the label CI failed on Sep 21, 2023
  9. maflcko commented at 11:00 AM on September 21, 2023: member

    lgtm ACK d05be124dbc0b24fb69d0c28ba2d6b297d243751

  10. maflcko added this to the milestone 26.0 on Sep 21, 2023
  11. fanquake merged this on Sep 21, 2023
  12. fanquake closed this on Sep 21, 2023

  13. Frank-GER referenced this in commit 3898c3faea on Sep 25, 2023
  14. sidhujag referenced this in commit add26a2d67 on Sep 26, 2023
  15. bitcoin locked this on Sep 20, 2024


josibakeglozow

Labels

Milestone
26.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me