http: update libevent workaround to correct version #27949

1. 
   stickies-v commented at 4:28 pm on June 23, 2023: contributor

   The libevent bug described in https://github.com/libevent/libevent/commit/5ff8eb26371c4dc56f384b2de35bea2d87814779 was already patched in release-2.1.9-beta, with cherry-picked commits 5b40744d1581447f5b4496ee8d4807383e468e7a and b25813800f97179b2355a7b4b3557e6a7f568df2.

   There should be no side-effects by re-applying the workaround on an already patched version of libevent (as is currently done in master for people running libevent between 2.1.9 and 2.1.12), but it is best to just set the correct version number to avoid confusion.

   This will prevent situations like e.g. in #27909 (review), where a reverse workaround was incorrectly applied to the wrong version range.

2. http: update libevent workaround to correct version

   The libevent bug described in https://github.com/libevent/libevent/commit/5ff8eb26371c4dc56f384b2de35bea2d87814779
   was already patched in release-2.1.9-beta, with cherry-picked
   commits 5b40744d1581447f5b4496ee8d4807383e468e7a and
   b25813800f97179b2355a7b4b3557e6a7f568df2.
   
   There should be no side-effects by re-applying the workaround on
   an already patched version of libevent, but it is best to set the
   correct version number to avoid confusion.

   79d343a642
3. 
   DrahtBot commented at 4:28 pm on June 23, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake
   Concept ACK	pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27253 (httpserver, rest: improving URI validation by pablomartin4btc)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label RPC/REST/ZMQ on Jun 23, 2023
5. 
   pablomartin4btc commented at 8:57 am on June 24, 2023: member

   Concept ACK.

   I’ve checked the 2 fixes, checked the release-2.1.9-beta’s changelog, and after downloading the release-2.1.9-beta, checked that the changes are in there too.

6. fanquake approved
7. 
   fanquake commented at 11:06 am on June 28, 2023: member

   ACK 79d343a642f985801da463b03a0627a59a095238
8. fanquake merged this on Jun 28, 2023
9. fanquake closed this on Jun 28, 2023

   ---

10. stickies-v deleted the branch on Jun 28, 2023
11. sidhujag referenced this in commit 2e3d241436 on Jun 30, 2023
12. bitcoin locked this on Jun 27, 2024

Contributors
stickies-v DrahtBot pablomartin4btc fanquake

Labels
RPC/REST/ZMQ