net: remove unused CConnmanTest #27957

1. 
   brunoerg commented at 9:57 pm on June 23, 2023: contributor

   CConnmanTest was removed in fa72fce7c948185752a01002000ea511809146ed.
2. net: remove unused `CConnmanTest` 9f0d129565
3. 
   DrahtBot commented at 9:57 pm on June 23, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theStack
   Concept ACK	Ayush170-Future

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label P2P on Jun 23, 2023
5. Ayush170-Future approved
6. 
   Ayush170-Future commented at 10:47 pm on June 23, 2023: contributor

   ACK.

   I also used Github’s search feature to ensure that there are no other instances of CConnmanTest in the whole Bitcoin Core source code. So, this is the last one left.

7. theStack approved
8. 
   theStack commented at 12:31 pm on June 24, 2023: contributor

   ACK 9f0d129565f1f752e771670f2df93e94f6c4d880

   I was very surprised that it’s even possible to specify a non-existing struct as a friend. Some background on this topic: https://stackoverflow.com/questions/42008500/why-is-a-friend-class-not-verified-for-existence

9. fanquake merged this on Jun 26, 2023
10. fanquake closed this on Jun 26, 2023

    ---

11. sidhujag referenced this in commit 5956493cb7 on Jun 26, 2023
12. bitcoin locked this on Jun 25, 2024

Contributors
brunoerg DrahtBot Ayush170-Future theStack

Labels
P2P