CConnmanTest was removed in fa72fce7c948185752a01002000ea511809146ed.
net: remove unused `CConnmanTest` #27957
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-06-connman-remove-cconnmantest changing 1 files +0 −1-
brunoerg commented at 9:57 PM on June 23, 2023: contributor
-
net: remove unused `CConnmanTest` 9f0d129565
-
DrahtBot commented at 9:57 PM on June 23, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theStack Concept ACK Ayush170-Future If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label P2P on Jun 23, 2023
- Ayush170-Future approved
-
Ayush170-Future commented at 10:47 PM on June 23, 2023: contributor
ACK.
I also used Github's search feature to ensure that there are no other instances of
CConnmanTest in the whole Bitcoin Core source code. So, this is the last one left. - theStack approved
-
theStack commented at 12:31 PM on June 24, 2023: contributor
ACK 9f0d129565f1f752e771670f2df93e94f6c4d880
I was very surprised that it's even possible to specify a non-existing struct as a
friend. Some background on this topic: https://stackoverflow.com/questions/42008500/why-is-a-friend-class-not-verified-for-existence - fanquake merged this on Jun 26, 2023
- fanquake closed this on Jun 26, 2023
- sidhujag referenced this in commit 5956493cb7 on Jun 26, 2023
- bitcoin locked this on Jun 25, 2024
Contributors
Labels