wallet: sqlite: don't include sqlite files from our headers #28040

pull theuni wants to merge 1 commits into bitcoin:master from theuni:sqlite-no-include-from-headers changing 1 files +3 −2

theuni commented at 8:06 PM on July 6, 2023: member

Only #include upstream sqlite headers from our cpp files.

Like #28039 but simpler :)
wallet: sqlite: force sqlite3.h to be included by the cpp files
This way sqlite usage is explicit.
bea9fc2600
DrahtBot commented at 8:06 PM on July 6, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK achow101, TheCharlatan, kristapsk, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Wallet on Jul 6, 2023
achow101 commented at 9:12 PM on July 6, 2023: member

ACK bea9fc2600635020fd28ec7a6613c92a6f349a86
maflcko approved
maflcko commented at 6:14 AM on July 7, 2023: member
lgtm. I wonder why iwyu can't transform those two symbols into forward decls. Output on master:
```
The full include-list for wallet/sqlite.h:
...
#include <sqlite3.h>    // for sqlite3_stmt, sqlite3
...
```
TheCharlatan approved
TheCharlatan commented at 7:30 AM on July 7, 2023: contributor

Nice, ACK bea9fc2600635020fd28ec7a6613c92a6f349a86
kristapsk approved
kristapsk commented at 7:34 AM on July 7, 2023: contributor

utACK bea9fc2600635020fd28ec7a6613c92a6f349a86
hebasto approved
hebasto commented at 8:13 AM on July 7, 2023: member

ACK bea9fc2600635020fd28ec7a6613c92a6f349a86, I have reviewed the code and it looks OK.
PRADACANDI18 approved
PRADACANDI18 commented at 8:35 AM on July 7, 2023: none

Looks good
fanquake merged this on Jul 7, 2023
fanquake closed this on Jul 7, 2023
sidhujag referenced this in commit d78a36326f on Jul 7, 2023
bitcoin locked this on Jul 6, 2024