Is this message still needed, given that we have had headers first sync for a very long time (https://github.com/bitcoin/bitcoin/pull/4468)?
rfc: Nuke getblocks message #28045
pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2023-07-nuke-getblocks changing 3 files +1 −93-
dergoegge commented at 1:41 PM on July 7, 2023: member
-
[net processing] Nuke getblocks message c2176d5e51
-
DrahtBot commented at 1:41 PM on July 7, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
sipa commented at 1:43 PM on July 7, 2023: member
Yes, not every implementation of the P2P protocol uses headers-first sync.
-
0xB10C commented at 2:06 PM on July 7, 2023: contributor
I have a
-peerbloomfilters=1node that receives a fewgetblocksmessages per minute. The peers have/BitcoinKit:0.1.0/,/WalletKit:0.1.0/,/bread:2.1/as user-agents. -
dergoegge commented at 2:13 PM on July 7, 2023: member
I have a -peerbloomfilters=1 node that receives a few getblocks messages per minute.
Alright closing.
- dergoegge closed this on Jul 7, 2023
-
maflcko commented at 2:20 PM on July 7, 2023: member
It may be good to add basic tests for this feature, otherwise the risk is that it will break eventually and no one noticing for a long time, since there are only few users and existing nodes will continue to reply to messages for the time they are still running?
- bitcoin locked this on Jul 6, 2024
