The node in this test was never really needed, because the compatibility tests shouldn't be used to test previous releases. (The test suite of the previous release itself should be used for that). So remove it.
Also, other test changes. (See individual commits)
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | theStack |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
No conflicts as of last run.
Concept ACK
Small note: regarding using clean chain in feature_txindex_compatibility.py, is there any obvious advantage of re-generating blocks on every test-run rather than simply using the pre-generated one that's shared between tests? Probably both approaches are fine, Just wondering what's our general strategy here.
Good question. If the cached test blockdir is stored in XOR format (https://github.com/bitcoin/bitcoin/pull/28052), it obviously can't be read by previous tests. So I can just drop the change here, and instead defer it to the later pull. Also, it may be good to include a compat test in the later pull?
The test creates enough blocks itself, so there is no need to have more.
Also, remove os import.
* The node was only used to migrate the legacy txindex. But now that it
is known to be working and that 22.x is EOL, it can be dropped.
* Also, fix a typo to properly check the txindex of node [1], not [2].
-BEGIN VERIFY SCRIPT-
sed -i 's|].chain_path / "blocks"|].blocks_path|g' $(git grep -l chain_path)
-END VERIFY SCRIPT-
Dropped that change for now, to save it for a later pull.
Code-review ACK fafe43cb6c76a5f60194be128a40baf161d39920
Additional replacement suggestion for the scripted-diff (last commit), to also tackle chain_path + "blocks" concatenations that are done via os.path.join:
sed -i 's|].chain_path, "blocks"|].blocks_path|g' $(git grep -l chain_path)
Looks like this was merged, so I'll submit the scripted diff in the follow-up
Follow-up in https://github.com/bitcoin/bitcoin/pull/28195