There are a few functions in httpserver.cpp (HTTPBindAddresses and UnregisterHTTPHandler) that are declaring std::vector::iterator explicitly, which is really verbose and visually noisy. My guess is that they were written pre-C++11 and they would be written differently today, so I modified them a little and used auto instead.
Also, I inverted the logic of an if block in UnregisterHTTPHandler in order to remove a nesting level.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
Thank you for your contribution. While this stylistic change makes sense on its own, it comes at a cost and risk for the project as a whole. The weak motivation for the change does not justify the burden that it places on the project. A burden could be any of the following:
For more information about refactoring changes and stylistic cleanup, see
Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.
Let us know if you have any questions.
329 | @@ -330,7 +330,7 @@ static bool HTTPBindAddresses(struct evhttp* http) 330 | } 331 | 332 | // Bind addresses 333 | - for (std::vector<std::pair<std::string, uint16_t> >::iterator i = endpoints.begin(); i != endpoints.end(); ++i) { 334 | + for (auto i = endpoints.begin(); i != endpoints.end(); ++i) {
Should probably use the C++17 structured bindings, but again, probably not worth to change it, unless there are other changes
Closing for now. If you are looking for something else to work on, see:
New developers are very welcome and needed. There are a lot of open issues of any difficulty waiting to be fixed. However, before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set.
If you need more help getting started, please refer to the following resources:
If you are looking for useful contributions to help out with, you can