This doesn't produce any additional warnings for me under GCC 13 or Clang 16, so it'd seem useful to use the less restricted unused code warning.
-Wno-unused-parameter is still required.
build: promote -Wunused-member-function to -Wunused #28102
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:uplift_to_wunused changing 1 files +1 −1-
fanquake commented at 9:26 AM on July 19, 2023: member
-
2bf0bee717
build: promote -Wunused-member-function to -Wunused
This doesn't produce any additional warnings for me under GCC 13 or Clang 16, so it'd seem useful to use the less restricted unused code warning. `-Wno-unused-parameter` is still required.
-
DrahtBot commented at 9:26 AM on July 19, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Build system on Jul 19, 2023
-
maflcko commented at 10:10 AM on July 19, 2023: member
For gcc this is already in Wall. Not sure for clang.
Not sure if related: https://cirrus-ci.com/task/6059497324544000?logs=ci#L2338
-
-
fanquake commented at 10:36 AM on July 19, 2023: member
Not sure if related: https://cirrus-ci.com/task/6059497324544000?logs=ci#L2338
I thought we'd cleaned these up at some point, can be left as-is in any case.
- fanquake closed this on Jul 19, 2023
- fanquake deleted the branch on Jul 19, 2023
- bitcoin locked this on Jul 18, 2024
Labels