test: blockstore test with chattr instead of chmod #28171

pull pinheadmz wants to merge 3 commits into bitcoin:master from pinheadmz:blockstore-tests-chattr changing 4 files +126 −1
  1. pinheadmz commented at 4:00 pm on July 27, 2023: member

    alternative to #27850

    see #27850 (comment)

    just testing ci for now

  2. DrahtBot commented at 4:00 pm on July 27, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #28161 (ci: Move ASan USDT to persistent_worker by MarcoFalke)
    • #27850 (test: Add unit & functional test coverage for blockstore by pinheadmz)
    • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Tests on Jul 27, 2023
  4. unit test: add coverage for BlockManager fb772fcb88
  5. pinheadmz force-pushed on Jul 27, 2023
  6. DrahtBot added the label CI failed on Jul 27, 2023
  7. ci: add immutability flag capability to docker containers 7e34d93bb9
  8. test: cover read-only blockstore c51ece9d03
  9. pinheadmz force-pushed on Jul 27, 2023
  10. in ci/test/04_install.sh:22 in c51ece9d03
    18@@ -19,7 +19,7 @@ export LSAN_OPTIONS="suppressions=${BASE_ROOT_DIR}/test/sanitizer_suppressions/l
    19 export TSAN_OPTIONS="suppressions=${BASE_ROOT_DIR}/test/sanitizer_suppressions/tsan:halt_on_error=1:log_path=${BASE_SCRATCH_DIR}/sanitizer-output/tsan"
    20 export UBSAN_OPTIONS="suppressions=${BASE_ROOT_DIR}/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1"
    21 if [[ $BITCOIN_CONFIG = *--with-sanitizers=*address* ]]; then # If ran with (ASan + LSan), Docker needs access to ptrace (https://github.com/google/sanitizers/issues/764)
    22-  CI_CONTAINER_CAP="--cap-add SYS_PTRACE"
    23+  CI_CONTAINER_CAP="--cap-add SYS_PTRACE --cap-add LINUX_IMMUTABLE"
    


    MarcoFalke commented at 6:12 am on July 28, 2023:
    This has nothing to do with asan, you will have to add it to all created containers.
  11. MarcoFalke changes_requested
  12. MarcoFalke commented at 6:16 am on July 28, 2023: member
    I think you can just use the existing pull request to push the changes. It is clear that this approach will be working. Just pay attention to the details and make sure you are confident in your diff before you push, if possible.
  13. MarcoFalke closed this on Jul 28, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me