ci: Use documented CCACHE_MAXSIZE instead of CCACHE_SIZE #28188

1. 
   hebasto commented at 8:50 pm on July 30, 2023: member

   This PR aims to:

   1. Remove our own CCACHE_SIZE environment variable that violates Ccache’s CCACHE_* namespace.
   2. Introduce the CCACHE_MAXSIZE environment variable that is documented since v3.3, which makes its usage consistent with other ones, such as CCACHE_DIR and CCACHE_NOHASHDIR.
2. ci: Use documented `CCACHE_MAXSIZE` instead of `CCACHE_SIZE`

   This change aims to:
   1) Remove our own `CCACHE_SIZE` environment variable that violates
   Ccache's `CCACHE_*` namespace.
   2) Introduce the `CCACHE_MAXSIZE` environment variable that is
   documented since v3.3, which makes its usage consistent with other ones,
   such as `CCACHE_DIR` and `CCACHE_NOHASHDIR`.

   79ceb161db
3. 
   DrahtBot commented at 8:50 pm on July 30, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarcoFalke

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28173 (ci: Run Windows native task on GitHub Actions by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Jul 30, 2023
5. hebasto force-pushed on Jul 30, 2023
6. DrahtBot added the label CI failed on Jul 30, 2023
7. 
   maflcko commented at 8:21 am on July 31, 2023: member

   lgtm ACK 79ceb161dbf7e033ce557d98e297bc3333665f26
8. DrahtBot removed the label CI failed on Jul 31, 2023
9. 
   fanquake commented at 10:16 am on July 31, 2023: member

   Looks like this is still working as intended, and the cache sizes are being set, i.e 250mb for the msan job https://cirrus-ci.com/task/5055152978132992?logs=ci#L1997:

   0Cache size (GB): 0.22 / 0.25 (86.73 %)
   

10. fanquake merged this on Jul 31, 2023
11. fanquake closed this on Jul 31, 2023

    ---

12. 
    jonatack commented at 8:47 pm on July 31, 2023: member

    Post-merge ACK
13. hebasto deleted the branch on Aug 1, 2023
14. sidhujag referenced this in commit 91a4b313c0 on Aug 9, 2023
15. bitcoin locked this on Jul 31, 2024

Contributors
hebasto DrahtBot maflcko fanquake jonatack

Labels
Tests