test: python E721 and flake8 updates #28194

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:2023-07-python-E721-and-flake8-update changing 4 files +5 −5
  1. jonatack commented at 6:29 PM on July 31, 2023: member

    Update our functional tests per E721 enforced by flake8 6.1.0, and update our CI lint task to use that release. This makes the following linter output on current master with flake8 6.1.0 green.

    $ ./test/lint/lint-python.py ; ./test/lint/lint-spelling.py 
    test/functional/p2p_invalid_locator.py:35:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
    test/functional/test_framework/siphash.py:34:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
    test/functional/test_framework/siphash.py:64:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
    src/test/fuzz/descriptor_parse.cpp:88: occurences ==> occurrences
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
    
  2. test: python E721 updates 38c3fd846b
  3. script: update flake8 to 6.1.0
    and touch up the spelling returned by lint-spelling.py
    bee2d57a65
  4. DrahtBot commented at 6:30 PM on July 31, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. jonatack commented at 6:53 PM on July 31, 2023: member

    CI lint task report looks good https://cirrus-ci.com/task/6522164438892544.

  6. jonatack marked this as ready for review on Jul 31, 2023
  7. maflcko commented at 5:54 AM on August 1, 2023: member

    lgtm ACK bee2d57a655645dbfaf0242e85c5af034023a2fb

  8. DrahtBot renamed this:
    test, script: python E721 and flake8 updates
    test: python E721 and flake8 updates
    on Aug 1, 2023
  9. DrahtBot added the label Tests on Aug 1, 2023
  10. fanquake merged this on Aug 1, 2023
  11. fanquake closed this on Aug 1, 2023

  12. jonatack deleted the branch on Aug 1, 2023
  13. sidhujag referenced this in commit 048d8dcb7a on Aug 9, 2023
  14. bitcoin locked this on Jul 31, 2024
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me