build: Bump clang minimum supported version to 13

maflcko commented at 12:32 pm on August 3, 2023: member

All supported operating systems ship with clang-13 (or later), so bump the minimum to that and remove now unused workarounds for previous clang bugs.

For reference:

https://packages.debian.org/bullseye/clang-13
https://packages.ubuntu.com/jammy/clang (clang-14) and https://packages.ubuntu.com/jammy/clang-15
CentOS-like 8/9 Stream: All Clang versions from 13 to 15
FreeBSD 12/13: All Clang version from 13 to 16
OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (clang16); No idea about OpenSuse Leap

This is for Bitcoin Core 27.0 in 2024 (next year), not the soon upcoming 26.0 next month.

DrahtBot commented at 12:32 pm on August 3, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28686 (refactor: Split per-peer parts of net module into new node/connection module by ajtowns)
#28348 (build: Bump g++ minimum supported version to 10 by maflcko)
#26022 (Add util::ResultPtr class by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Aug 3, 2023

maflcko added this to the milestone 27.0 on Aug 3, 2023

maflcko commented at 1:17 pm on August 3, 2023: member

This fails on macOS 11.0, according to CI. So I guess this can be closed for now.

maflcko added the label DrahtBot Guix build requested on Aug 3, 2023

DrahtBot added the label CI failed on Aug 3, 2023

fanquake commented at 4:51 pm on August 3, 2023: member

This fails on macOS 11.0,

Yea, this’ll at least need to wait for the macOS compiler bump, but the next time that happens (soon) it will be from 11 to 16, if not 17.

DrahtBot commented at 10:34 pm on August 3, 2023: contributor

Guix builds

File	commit 7c66a4b6109c01b79979128ef23e63fc733f89ba(master)	commit 09dd23072150f156b2ce93e6d0404178ed82b2e4(master and this pull)
SHA256SUMS.part	`f1ea8819c5a564a6...`	`6a69d06d9b380559...`
*-aarch64-linux-gnu-debug.tar.gz	`fec95a0e7a02362c...`	`135b6423cf9fb06e...`
*-aarch64-linux-gnu.tar.gz	`14ebb3ca98553fc5...`	`473d24aeca9c55e3...`
*-arm-linux-gnueabihf-debug.tar.gz	`0ca7b4dcfd771cac...`	`d2f4164338e059c9...`
*-arm-linux-gnueabihf.tar.gz	`9edf67b30a765e82...`	`696dbeb56974f2e1...`
*-arm64-apple-darwin-unsigned.dmg	`6d0f8fa3fe700836...`
*-arm64-apple-darwin-unsigned.tar.gz	`e43bf0cdea1bc892...`
*-arm64-apple-darwin.tar.gz	`bf4249018c3b58a8...`
*-powerpc64-linux-gnu-debug.tar.gz	`961e9f43562ac206...`	`127780061a07f0c8...`
*-powerpc64-linux-gnu.tar.gz	`e39abba2d6a364df...`	`f31008e4f0adecc7...`
*-powerpc64le-linux-gnu-debug.tar.gz	`967d0d2135d7e6f0...`	`a96fbaec143e1ea0...`
*-powerpc64le-linux-gnu.tar.gz	`0e227a39b05338dc...`	`6873f96bff363215...`
*-riscv64-linux-gnu-debug.tar.gz	`0e802565dfa259c6...`	`0511c8bbc75f333a...`
*-riscv64-linux-gnu.tar.gz	`12f8c850e0884057...`	`de73c2301b3bb53d...`
*-x86_64-apple-darwin-unsigned.dmg	`3b1e499e75c16f77...`
*-x86_64-apple-darwin-unsigned.tar.gz	`1726002d89e15316...`
*-x86_64-apple-darwin.tar.gz	`5c702cd8c5dff36d...`
*-x86_64-linux-gnu-debug.tar.gz	`42a9e736ca1555cf...`	`0dc7f7dce4bfd81e...`
*-x86_64-linux-gnu.tar.gz	`bf4892239cab6e48...`	`a829b3ffd800361a...`
*.tar.gz	`70e97dbd476e0c3d...`	`749b2781a7ac5798...`
guix_build.log	`d21931bc7b08a487...`	`2edbc3e197d4bf3d...`
guix_build.log.diff		`70ce68314ebb705f...`

DrahtBot removed the label DrahtBot Guix build requested on Aug 3, 2023

DrahtBot added the label Needs rebase on Aug 9, 2023

maflcko force-pushed on Aug 15, 2023

DrahtBot removed the label Needs rebase on Aug 15, 2023

maflcko force-pushed on Aug 23, 2023

DrahtBot added the label Needs rebase on Aug 24, 2023

maflcko force-pushed on Aug 24, 2023

fanquake commented at 12:35 pm on August 24, 2023: member

If you want pull in https://github.com/fanquake/bitcoin/commit/fc8f7ae32dc16526fe2f155422781bfbc7e9f326, should be enough for green macOS cross-compile CI. Tested once locally.

maflcko commented at 12:38 pm on August 24, 2023: member

Happy to rebase on that, once and if it is merged. I think it is better to keep the changes here to CI/doc-only.

DrahtBot removed the label Needs rebase on Aug 24, 2023

maflcko renamed this:
~~build: Bump minimum supported Clang to clang-13~~
build: Bump clang minimum supported version to 13
on Aug 27, 2023

fanquake referenced this in commit 8371914604 on Aug 27, 2023

fanquake commented at 1:55 pm on August 27, 2023: member

CI should be all green on next rebase.

DrahtBot removed the label CI failed on Aug 27, 2023

maflcko added the label DrahtBot Guix build requested on Sep 5, 2023

DrahtBot commented at 2:04 am on September 6, 2023: contributor

Guix builds (on x86_64)

File	commit 9d3b216e009a53ffcecd57e7f10df15cccd5fd6d(master)	commit c4dde7998e12a006fe1eda0f4b1f6008509864d4(master and this pull)
SHA256SUMS.part	`3c57cd8199c723d6...`	`fbc193b46aad963c...`
*-aarch64-linux-gnu-debug.tar.gz	`b3be5bf8b13acd79...`	`22f9ae26e201effa...`
*-aarch64-linux-gnu.tar.gz	`9e53fc8bdaae2991...`	`ab292d1883f6220d...`
*-arm-linux-gnueabihf-debug.tar.gz	`2da52974294d7aa7...`	`55fb368e2de17b78...`
*-arm-linux-gnueabihf.tar.gz	`849397fb888189c0...`	`341f00db03a3cc41...`
*-arm64-apple-darwin-unsigned.dmg	`83850133c42db63f...`	`d15939050d07ab5a...`
*-arm64-apple-darwin-unsigned.tar.gz	`198c1392640d6281...`	`39a9bf7130534e57...`
*-arm64-apple-darwin.tar.gz	`577cff9bca290b78...`	`08c92c612202c388...`
*-powerpc64-linux-gnu-debug.tar.gz	`df855e3842293446...`	`4aede9d81c195a28...`
*-powerpc64-linux-gnu.tar.gz	`6dbc4447804f6cfe...`	`a9aaa4370c461356...`
*-powerpc64le-linux-gnu-debug.tar.gz	`394cf58d49da4576...`	`19248202a1a9a3a3...`
*-powerpc64le-linux-gnu.tar.gz	`d4bc7a07b39cffe9...`	`4e5f77f3bbf7c243...`
*-riscv64-linux-gnu-debug.tar.gz	`53fe0d40b995b2f3...`	`9cdbf73dfe66fc53...`
*-riscv64-linux-gnu.tar.gz	`6fe76c88c2922c51...`	`a8685126ef60f4a2...`
*-x86_64-apple-darwin-unsigned.dmg	`5808e1822110dd7f...`	`946983e879b105f4...`
*-x86_64-apple-darwin-unsigned.tar.gz	`520cbaa034c71b5b...`	`bb0af9cb2cb54b2d...`
*-x86_64-apple-darwin.tar.gz	`9cf60f219aa2bfba...`	`5ed8b4a85aec043c...`
*-x86_64-linux-gnu-debug.tar.gz	`ffd9cc7139745a85...`	`488ad15c17120bb7...`
*-x86_64-linux-gnu.tar.gz	`61204c2275003f89...`	`d6a144fc01489b97...`
*.tar.gz	`99ad0782b2c9f90d...`	`2beb65f0e756c533...`
guix_build.log	`e857c1500e6e0d32...`	`a7e84d02febaf7c2...`
guix_build.log.diff		`47744e994ac655af...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 6, 2023

Frank-GER referenced this in commit c6be2a4da0 on Sep 8, 2023

fanquake commented at 1:18 pm on September 12, 2023: member

Concept ACK

maflcko force-pushed on Sep 23, 2023

maflcko commented at 11:04 am on September 23, 2023: member

Rebased to remove two more unused std::move. Still in draft until after 26.x branch-off.

hebasto commented at 11:16 am on September 23, 2023: member

This is for Bitcoin Core 27.0 in 2024

Concept ACK.

hebasto commented at 11:37 am on September 23, 2023: member

Just to clarify, does this mean that we will drop support for Ubuntu 20.04 LTS as a build platform for Bitcoin Core v27.0 in 2024, even though its End of Standard Support is in 2025?

maflcko commented at 3:51 pm on September 23, 2023: member

Just to clarify, does this mean that we will drop support for Ubuntu 20.04 LTS as a build platform for Bitcoin Core v27.0 in 2024, even though its End of Standard Support is in 2025?

No. Anyone on 20.04 can install a supported compiler, for example clang-13. There are many ways to install a compiler on Linux, for example:

The vanilla package manager, for example https://packages.ubuntu.com/focal/g++-10
Another ppa, for example the “clang nightly” ppa
nix
Compile from source
…

PastaPastaPasta referenced this in commit fddae491fc on Oct 11, 2023

maflcko force-pushed on Oct 24, 2023

Bump .python-version from 3.9.17 to 3.9.18

Requested in https://github.com/bitcoin/bitcoin/pull/28211/files#r1309945635

fab1ef9512

build: Bump minimum supported Clang to clang-13 fae379b6b1

maflcko force-pushed on Oct 24, 2023

maflcko marked this as ready for review on Oct 24, 2023

maflcko added the label DrahtBot Guix build requested on Oct 24, 2023

fanquake commented at 8:43 pm on October 24, 2023: member

ACK fae379b6b1c9d434821acc348f010d67c4fee927

DrahtBot requested review from hebasto on Oct 24, 2023

fanquake merged this on Oct 24, 2023

fanquake closed this on Oct 24, 2023

DrahtBot commented at 1:39 am on October 25, 2023: contributor

Guix builds (on x86_64)

File	commit 43704827b4c9c178f3651a005e26c09103cd4189(master)	commit 8d05fba02f658f68de3cdeea92d1f53782c97d37(master and this pull)
SHA256SUMS.part	`183387813ca7437c...`	`1c091be339920b50...`
*-aarch64-linux-gnu-debug.tar.gz	`dbe14eca3b7590f9...`	`cd3a238ed7dac501...`
*-aarch64-linux-gnu.tar.gz	`86e581c5aa6288be...`	`810b75c084d7cdc7...`
*-arm-linux-gnueabihf-debug.tar.gz	`1be1acedf78a3446...`	`04e4ed17c8976694...`
*-arm-linux-gnueabihf.tar.gz	`09c5d6abefb45f51...`	`afbd9fd834be959f...`
*-arm64-apple-darwin-unsigned.tar.gz	`f6d41940fd261af9...`	`c38c0648e74af4f0...`
*-arm64-apple-darwin-unsigned.zip	`268791efe0de4e07...`	`4e7e4ff215e3690b...`
*-arm64-apple-darwin.tar.gz	`b6dadb8374975f5f...`	`5a077e8d368cc190...`
*-powerpc64-linux-gnu-debug.tar.gz	`ebe3060f3de9d6d0...`	`9b13ce46a3760021...`
*-powerpc64-linux-gnu.tar.gz	`e6eac3cef68d41a6...`	`7d0a70d146404acf...`
*-powerpc64le-linux-gnu-debug.tar.gz	`4ffd1440c7990acb...`	`75dba1caaab07d2c...`
*-powerpc64le-linux-gnu.tar.gz	`0b6bcd94d3c4b455...`	`be7d5d7f091fff14...`
*-riscv64-linux-gnu-debug.tar.gz	`36928faea0e41f47...`	`e9e497c3ae8c828b...`
*-riscv64-linux-gnu.tar.gz	`53e7196be616f7fa...`	`b0275528db455f55...`
*-x86_64-apple-darwin-unsigned.tar.gz	`b51b362bd8e1f7bf...`	`f53c0b87d040fdb0...`
*-x86_64-apple-darwin-unsigned.zip	`a96fe067ca443670...`	`8b99f2199fd4854a...`
*-x86_64-apple-darwin.tar.gz	`062eb82c207dbebb...`	`0acbff16e6d42f72...`
*-x86_64-linux-gnu-debug.tar.gz	`934752412e800e61...`	`0e75e243e5a35f18...`
*-x86_64-linux-gnu.tar.gz	`23e28d2b322eeaf4...`	`1d33e710f1cc5769...`
*.tar.gz	`c49c626683702ab1...`	`f3fc477067f901f4...`
guix_build.log	`be39534ef95fdc39...`	`d63ae96aca0ee56f...`
guix_build.log.diff		`5ed5ea4f9c00a2c1...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 25, 2023

maflcko deleted the branch on Oct 25, 2023

hebasto commented at 9:25 am on October 25, 2023: member

Post-merge ACK.

build: Bump clang minimum supported version to 13 #28210

Code Coverage

Reviews

Conflicts

Guix builds

Guix builds (on x86_64)

Guix builds (on x86_64)