follow-up to #28008.
dummy_tag variable in FSChaCha20Poly1305 crypto_tests outside of the loop to be reused every timecipher.last() in AEADChaCha20Poly1305::Decrypt()BIP324Cipher::Initialize()aad in bip324 fuzz test
follow-up to #28008.
* move `dummy_tag` variable in FSChaCha20Poly1305 crypto_tests
outside of the loop to be reused every time
* use easy to read `cipher.last()` in `AEADChaCha20Poly1305::Decrypt()`
* comment for initiator in `BIP324Cipher::Initialize()`
* systematically damage ciphertext with bit positions in bip324_tests
* use 4095 max bytes for aad in bip324 fuzz test
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
When touching this file, could add the missing include?
0bip324.h should add these lines:
1#include <array>
See the full iwyu output: https://api.cirrus-ci.com/v1/task/4946847257591808/logs/ci.log (Search for $filename should or $filename has the correct)
(Same for crypto/chacha20poly1305.cpp)
(Maybe only if you have to re-touch, or as a new commit)
10@@ -11,8 +11,10 @@
11 #include <util/strencodings.h>
12
13 #include <array>
14-#include <vector>
15 #include <cstddef>
16+#include <span.h>
17+#include <stdint.h>
Note that we keep our includes, and stardard library headers separate, so span.h should be added above. We also try use the cpp headers, so cstdint over stdint.h (regardless of what IWYU suggests).
0#include <cstdint>