refactor: Remove confusing static_cast in address types #28284

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2308-no-static_cast- changing 2 files +13 −9
  1. maflcko commented at 1:59 pm on August 17, 2023: member

    It seems confusing to use static_cast<uint160>(bla) to call the constructor of uint160. The normal and common way to call a constructor is by simply calling it. (uint160{bla}).

    Do this, and also drop the constructor completely where the existing const& reference is enough.

    Also, add missing includes while touching the file.

  2. refactor: Add missing includes faeea1ab58
  3. Refactor: Remove confusing static_cast fadf671fa5
  4. DrahtBot commented at 1:59 pm on August 17, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK vincenzopalazzo, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot added the label Refactoring on Aug 17, 2023
  6. TheCharlatan commented at 2:22 pm on August 17, 2023: contributor
    Concept ACK
  7. DrahtBot added the label CI failed on Aug 17, 2023
  8. maflcko requested review from Empact on Aug 18, 2023
  9. DrahtBot removed the label CI failed on Aug 18, 2023
  10. fanquake requested review from achow101 on Aug 18, 2023
  11. vincenzopalazzo approved
  12. TheCharlatan approved
  13. TheCharlatan commented at 12:07 pm on August 22, 2023: contributor
    ACK fadf671fa539e76d000a08b92109ea5503d5f3ac
  14. fanquake merged this on Aug 22, 2023
  15. fanquake closed this on Aug 22, 2023

  16. maflcko deleted the branch on Aug 22, 2023
  17. Frank-GER referenced this in commit 702405d6ee on Sep 8, 2023
  18. bitcoin locked this on Aug 21, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me