ci: Disable –coverage temporarily #28285

1. 
   maflcko commented at 5:07 pm on August 17, 2023: member

   Looks like this causes all CI builds to be red, and doesn’t work anyway, see #27593 . Temporarily disable it to allow for more time to rework it from scratch.
2. ci: Disable --coverage temporarily fa4776bcbc
3. 
   DrahtBot commented at 5:07 pm on August 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	jonatack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Aug 17, 2023
5. 
   maflcko commented at 5:44 pm on August 17, 2023: member

   Looks like CI is red since https://github.com/bitcoin/bitcoin/commit/ecb20563b6a0cdd615628da9caa1e7389998119c, but on the pull, it passed last week: https://cirrus-ci.com/task/5524872076460032
6. 
   jonatack commented at 8:22 pm on August 17, 2023: member

   ACK based on green CI

   Perhaps the following would be better instead, so test/functional/test_runner.py --coverage run locally (as well as in the CI) doesn’t needlessly report missing coverage.

    0diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
    1index d93e6fd6da2..14e3a140485 100755
    2--- a/test/functional/test_runner.py
    3+++ b/test/functional/test_runner.py
    4@@ -847,7 +576,7 @@ class RPCCoverage():
    5         all_cmds = set()
    6         # Consider RPC generate covered, because it is overloaded in
    7         # test_framework/test_node.py and not seen by the coverage check.
    8-        covered_cmds = set({'generate'})
    9+        # Consider "Internal" to be covered due to the following issue until it is resolved:
   10+        # [#27593](/bitcoin-bitcoin/27593/)
   11+        covered_cmds = set({'Internal', 'generate'})
   

   Edit: #28289 seems even better.

7. 
   mzumsande commented at 8:26 pm on August 17, 2023: contributor

   The root cause for the CI failures is silent merge conflict that should be fixed by #28289 (we might still disable --coverage though, no opinion on that).
8. maflcko closed this on Aug 18, 2023

   ---

9. maflcko deleted the branch on Aug 18, 2023
10. bitcoin locked this on Aug 17, 2024

Contributors
maflcko DrahtBot jonatack mzumsande

Labels
Tests