Looks like this causes all CI builds to be red, and doesn't work anyway, see #27593 . Temporarily disable it to allow for more time to rework it from scratch.
ci: Disable --coverage temporarily #28285
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2308-ci-no-cov- changing 1 files +1 −1-
maflcko commented at 5:07 PM on August 17, 2023: member
-
ci: Disable --coverage temporarily fa4776bcbc
-
DrahtBot commented at 5:07 PM on August 17, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept ACK jonatack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Aug 17, 2023
-
maflcko commented at 5:44 PM on August 17, 2023: member
Looks like CI is red since https://github.com/bitcoin/bitcoin/commit/ecb20563b6a0cdd615628da9caa1e7389998119c, but on the pull, it passed last week: https://cirrus-ci.com/task/5524872076460032
-
jonatack commented at 8:22 PM on August 17, 2023: member
ACK based on green CI
Perhaps the following would be better instead, so
test/functional/test_runner.py --coveragerun locally (as well as in the CI) doesn't needlessly report missing coverage.diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index d93e6fd6da2..14e3a140485 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -847,7 +576,7 @@ class RPCCoverage(): all_cmds = set() # Consider RPC generate covered, because it is overloaded in # test_framework/test_node.py and not seen by the coverage check. - covered_cmds = set({'generate'}) + # Consider "Internal" to be covered due to the following issue until it is resolved: + # [#27593](/bitcoin-bitcoin/27593/) + covered_cmds = set({'Internal', 'generate'})Edit: #28289 seems even better.
- maflcko closed this on Aug 18, 2023
- maflcko deleted the branch on Aug 18, 2023
- bitcoin locked this on Aug 17, 2024