BIP 32 derivation + test vectors #2829

pull sipa wants to merge 4 commits into bitcoin:master from sipa:bip32 changing 9 files +585 −36

sipa commented at 11:10 PM on July 14, 2013: member

This does not add actual deterministic wallet functionality yet, only an implementation of BIP32 derivation and its test vectors.

I'm usually not in favor of adding code that isn't used yet, but in this case it may be useful to give a "reference implementation" exposure.
Add HMAC-SHA512 to hash 12dff9801f
Generalize version bytes 8388289eb6
BIP32 derivation implementation eb2c999050
BIP32 test vectors a59db19ee3
BitcoinPullTester commented at 9:04 PM on July 18, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a59db19ee3b454680b3bb0aa881e601b9311a9ae for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
simondlr commented at 9:46 AM on July 27, 2013: contributor

Do you plan on eventually implementing full BIP 32 support into Bitcoin-QT?
sipa commented at 11:29 AM on July 27, 2013: member

@simondlr Of course.
simondlr commented at 12:24 PM on July 27, 2013: contributor

@sipa Awesome! Looking forward to it.
sipa commented at 10:20 PM on August 15, 2013: member

@gavinandresen @jgarzik @gmaxwell Opinions?
gmaxwell commented at 10:31 PM on August 15, 2013: contributor

ACK. On the basis that this has already been used to validate other implementations and has even turned up some bugs, I think it would be good to include this.
jgarzik commented at 10:35 PM on August 15, 2013: contributor

ACK
gavinandresen referenced this in commit 13d3b1c144 on Aug 15, 2013
gavinandresen merged this on Aug 15, 2013
gavinandresen closed this on Aug 15, 2013
Bushstar referenced this in commit 208406df71 on Apr 5, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#23199 refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization