P2SH related RPC improvements #2830

pull petertodd wants to merge 3 commits into bitcoin:master from petertodd:p2sh-rpc changing 5 files +69 −38

petertodd commented at 7:19 AM on July 15, 2013: contributor

Some currently missing features like decoding a script and adding a specific P2SH redeemScript to the wallet.
jgarzik commented at 3:07 PM on July 22, 2013: contributor

ACK
petertodd commented at 9:02 PM on July 26, 2013: contributor

Note: should be merged after sipa's watch-only address stuff is merged, and modified to work with it.
sipa commented at 12:14 AM on July 29, 2013: member

Related to that, is addredeemscript useful, if bitcoind has no logic to actually spend coins sent to anything but what is creatable through createmultisigaddress?
sipa commented at 12:15 AM on July 29, 2013: member

ACK on the other changes.
petertodd commented at 2:11 AM on July 29, 2013: contributor

@sipa Actually bitcoind can spend any P2SH-encoded scriptPubKey that it knows how to spend, so you can (currently) put a pay-to-pubkey or a pay-to-pubkey-hash in redeemScript and things will work fine. In any case I think the feature of adding arbitrary redeemScripts makes the most sense in the context of watch-only-wallets where the actual mechanism to spend the coins can be handled elsewhere.
gmaxwell commented at 2:52 AM on September 13, 2013: contributor

@petertodd Can you remove addredeemscript for now since it seems like the watch stuff is currently delayed?
Move Parse{Hash|Hex} to be usable by all RPC code 463c9710f5
Add RPC call decodescript be066fad7d
Make validateaddress provide redeemScript 2253642287
BitcoinPullTester commented at 3:40 AM on September 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/22536422878d05a7229f74726148dd50051c883f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gmaxwell commented at 3:50 AM on September 13, 2013: contributor

ACK, changes look good and I tested all 0,1, and 2 byte scripts in decodescript and tried out validateaddress on some p2sh and non-p2sh addresses.
gmaxwell referenced this in commit 4c5969b367 on Sep 13, 2013
gmaxwell merged this on Sep 13, 2013
gmaxwell closed this on Sep 13, 2013
petertodd deleted the branch on Sep 13, 2013
petertodd restored the branch on Sep 13, 2013
petertodd deleted the branch on Sep 13, 2013
Bushstar referenced this in commit 53b2162e28 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors