446 | @@ -447,10 +447,6 @@ if test "$CXXFLAGS_overridden" = "no"; then
447 | AX_CHECK_COMPILE_FLAG([-Wduplicated-cond], [WARN_CXXFLAGS="$WARN_CXXFLAGS -Wduplicated-cond"], [], [$CXXFLAG_WERROR])
448 | AX_CHECK_COMPILE_FLAG([-Wlogical-op], [WARN_CXXFLAGS="$WARN_CXXFLAGS -Wlogical-op"], [], [$CXXFLAG_WERROR])
449 | AX_CHECK_COMPILE_FLAG([-Woverloaded-virtual], [WARN_CXXFLAGS="$WARN_CXXFLAGS -Woverloaded-virtual"], [], [$CXXFLAG_WERROR])
450 | - dnl -Wsuggest-override is broken with GCC before 9.2
451 | - dnl https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010
452 | - AX_CHECK_COMPILE_FLAG([-Wsuggest-override], [WARN_CXXFLAGS="$WARN_CXXFLAGS -Wsuggest-override"], [], [$CXXFLAG_WERROR],
We should keep this, otherwise we won't have -Wsuggest-override turned on.
AX_CHECK_COMPILE_FLAG([-Wsuggest-override], [WARN_CXXFLAGS="$WARN_CXXFLAGS -Wsuggest-override"], [], [$CXXFLAG_WERROR])
Clang might still warn via on-by-default -Winconsistent-missing-override, but GCC wont produce anything.
Ah sorry, I wrongly assumed this disables the check. However, it seems to be using AC_LANG_SOURCE to enable it. I presume the correct fix would be to just remove the AC_LANG_SOURCE and unconditionally enable it?
Will do that now.
(also reverted the changes to the leveldb buildfile, because they still seem to be needed for gcc 13.2)
