This PR is intended to speed up the CI feedback for pull requests:
a PR opened against the current master branch:
this PR:
Suggested in #28173 (review):
An alternative would be to run them on non-pr pushes only. Failures should be rare enough to deal with them post-merge.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | MarcoFalke |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
261@@ -262,5 +262,7 @@ jobs:
262 run: py -3 test\util\rpcauth-test.py
263
264 - name: Run functional tests
265+ env:
266+ TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended --exclude feature_dbcrash' || '' }}
0 TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }}
If there is a reason to exclude this, it should be mentioned
0feature_dbcrash.py | ✓ Passed | 7086 s
job_id % n == 0, where n is the down-scaling factor, but then run them completely otherwise?
If there are any downsides, you can skip the functional tests on the master branch completely on
job_id % n == 0, wherenis the down-scaling factor, but then run them completely otherwise?
Let’s left it as is and see how it will go.
This change is intended to speed up the CI feedback for pull requests.