Remove m_is_test_chain, use ChainType directly #28376

1. 
   maflcko commented at 1:17 pm on August 31, 2023: member

   Motivation

   m_is_test_chain is a bool, which has the meaning m_chain_type!=MAIN. This is just bloats the code with test-only code, so it should be removed and be replaced by the equivalent meaning. See the output of git grep m_is_test_chain and the suggestion #28316 (comment)

   Possible solution

   -

   Useful Skills

   • Compiling Bitcoin Core from source
   • Running the C++ unit tests and the Python functional tests

   Guidance for new contributors

   Want to work on this issue?

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. maflcko added the label good first issue on Aug 31, 2023
3. maflcko renamed this:
   Remove m_is_test_chain
   Remove m_is_test_chain, use ChainType directly
   on Aug 31, 2023
4. 
   BrandonOdiwuor commented at 4:43 pm on August 31, 2023: contributor

   would like to work on this
5. 
   luke-jr commented at 9:06 pm on September 5, 2023: member

   Concept NACK. Someday, albeit perhaps not the near future, Bitcoin may have multiple non-test blockchains. No reason to work in the opposite direction.
6. 
   maflcko commented at 6:13 am on September 6, 2023: member

   If someone writes a patch to support multiple non-test blockchains, massive changes are needed, and a trivial one-line (or four-line) diff should be least of all problems.

   I still agree with the changes, but let’s move the discussion to #28379. No need to have two threads going on for one thing.

7. maflcko closed this on Sep 6, 2023

   ---

8. fanquake referenced this in commit f29091410d on Sep 21, 2023
9. bitcoin locked this on Sep 5, 2024

Contributors
maflcko BrandonOdiwuor luke-jr

Labels
good first issue