test: remove fixed timeouts from feature_config_args #28386

pull mzumsande wants to merge 1 commits into bitcoin:master from mzumsande:202308_feature_config_args_timeouts changing 1 files +0 −4
  1. mzumsande commented at 6:59 PM on September 1, 2023: contributor

    Fixes #28290

    These fixed timeouts aren't affected by the timeout_factor option and can therefore cause timeouts in slow environments. They are also unnecessary for the test because they measure the wrong thing: While there is an internal waiting time of 60s within ThreadOpenConnections (beginning only when that thread is started) for fixed seeds querying, the timeouts here don't measure that but the time from startup until a debug log message is encountered, during which many other things happen in init, so they don't make much sense to me in the first place.

  2. test: remove fixed timeouts from feature_config_args
    They cannot be scaled by the timeout_factor option and can
    therefore cause timeouts in slow environments.
    They are also not necessary for the test, since they measure time
    frome startup until a debug message is encountered, which
    is not restricted to 1 minute by any internal logic within bitcoind.
    fbcacd4cf0
  3. DrahtBot commented at 6:59 PM on September 1, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #28392 (test: Use pathlib over os path by ns-xvrn)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Tests on Sep 1, 2023
  5. maflcko commented at 8:42 AM on September 3, 2023: member

    lgtm ACK fbcacd4cf0dbe54e51f89cda05ff3db9e378ea12

  6. DrahtBot added the label CI failed on Sep 3, 2023
  7. DrahtBot removed the label CI failed on Sep 5, 2023
  8. maflcko commented at 7:29 AM on September 5, 2023: member

    rfm, or is anything left to be done here?

  9. fanquake merged this on Sep 5, 2023
  10. fanquake closed this on Sep 5, 2023

  11. mzumsande deleted the branch on Sep 5, 2023
  12. Frank-GER referenced this in commit 1c2c80b391 on Sep 8, 2023
  13. bitcoin locked this on Sep 4, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me