This simple PR adds missing test coverage for ignoring repeated getaddr requests (introduced in #7856, commit 66b07247a7a9e48e082502338176cc06edf61474):
https://github.com/bitcoin/bitcoin/blob/6f03c45f6bb5a6edaa3051968b6a1ca4f84d2ccb/src/net_processing.cpp#L4642-L4648
test: p2p: check that `getaddr` msgs are only responded once per connection #28396
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202309-test-add_ignore_repeated_getaddr_coverage changing 1 files +10 −0-
theStack commented at 12:29 PM on September 3, 2023: contributor
-
test: p2p: check that `getaddr` msgs are only responded once per connection 668aa6af8d
-
DrahtBot commented at 12:29 PM on September 3, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke, brunoerg If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Sep 3, 2023
-
maflcko commented at 12:37 PM on September 3, 2023: member
lgtm ACK 668aa6af8d5fbf047d43cf6f85f3335565637fb9
- DrahtBot added the label CI failed on Sep 3, 2023
- brunoerg approved
-
brunoerg commented at 6:43 PM on September 4, 2023: contributor
crACK 668aa6af8d5fbf047d43cf6f85f3335565637fb9
- DrahtBot removed the label CI failed on Sep 5, 2023
- fanquake merged this on Sep 5, 2023
- fanquake closed this on Sep 5, 2023
- theStack deleted the branch on Sep 5, 2023
- Frank-GER referenced this in commit 33256a3e9b on Sep 8, 2023
- bitcoin locked this on Sep 4, 2024
Labels