This reduces bloat, complexity, and makes tests less fragile to intermittent failures, see #27675 (review).
This should not cause any noticeable slowdown, or may even be faster, because active polling will be done at most once.
test: Combine sync_send_with_ping and sync_with_ping #28409
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2309-test-ping- changing 8 files +12 −16-
maflcko commented at 10:13 AM on September 5, 2023: member
-
test: Combine sync_send_with_ping and sync_with_ping fae0b21e6c
-
DrahtBot commented at 10:13 AM on September 5, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theStack Concept ACK glozow, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Sep 5, 2023
-
glozow commented at 12:20 PM on September 5, 2023: member
Concept ACK fae0b21e6c7a27f08ea8f8b49198c734f923b5da
Doesn't hurt to do it twice anyway. I think this is often what is intended.
-
TheCharlatan commented at 1:00 PM on September 5, 2023: contributor
Concept ACK
- fanquake requested review from theStack on Sep 6, 2023
- theStack approved
-
theStack commented at 3:15 PM on September 6, 2023: contributor
ACK fae0b21e6c7a27f08ea8f8b49198c734f923b5da 🏓
- fanquake merged this on Sep 6, 2023
- fanquake closed this on Sep 6, 2023
- Frank-GER referenced this in commit 285f33cff6 on Sep 8, 2023
- maflcko deleted the branch on Sep 11, 2023
- Fabcien referenced this in commit 2af41ff856 on Apr 15, 2024
- bitcoin locked this on Sep 10, 2024
Contributors
Labels