Boundary Limit ? #28439

issue ChrisMartl openend this issue on September 9, 2023
  1. ChrisMartl commented at 8:33 am on September 9, 2023: none

    @luke-jr @glozow @fanquake @MarcoFalke:

    Shouldn’t be here in code “less equal than” i.e. “<=” for determination if an UXTO is to be considered “dust”? https://github.com/bitcoin/bitcoin/blob/4e1a38c6df91f96ca8a2ef07413ffdb1d59c30cc/src/policy/policy.cpp#L67

  2. MarcoFalke commented at 3:14 pm on September 10, 2023: member
  3. MarcoFalke added the label TX fees and policy on Sep 10, 2023
  4. MarcoFalke added the label Questions and Help on Sep 10, 2023
  5. ChrisMartl commented at 3:20 pm on September 10, 2023: none

    If the comment is the specification for the code (regardless, if it is the way around), why then the default value for dustrelayfee is 0.00003000 and no 0.00003001?

    https://github.com/bitcoin/bitcoin/blob/c5a63ea56f8347139bd84e1669b378ecfb234c3c/src/policy/policy.h#L55

  6. MarcoFalke commented at 3:25 pm on September 10, 2023: member

    Again, is there anything that requires the default value or the code to be different? I am not sure what your question is.

    If the user-facing (or developer internal code) documentation is wrong or misleading, or missing, it should be fixed. However if the user-facing documentation and code comments are correct and consistent, there is nothing to be done here.

  7. ChrisMartl commented at 3:47 pm on September 10, 2023: none

    Formally comment, code and default value are coherent themselves.

    The “dust” consideration is in fact for a rate less than 3000 sat/kvB: i.e. 2999 sat/kvB equal or less relative to the hard coded default fee rate. Still a boundary limit and it could lead users to misunderstandings regarding the upper boundary limits for “dust” UXTOs.

    I wanted to make sure, if this coding (boundary limit) was intended. And in your answer, it is. Then, I see nothing to change here.

  8. MarcoFalke commented at 3:52 pm on September 10, 2023: member
    Closing for now. Pull requests with improvements are always welcome. Moreover, it is possible to re-open this issue or create a new issue referencing it, if there is need to.
  9. MarcoFalke closed this on Sep 10, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-01 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me