ci: Use nproc over MAKEJOBS in 01_base_install #28504

1. 
   maflcko commented at 9:36 am on September 19, 2023: member

   Currently $MAKEJOBS is the default value in 01_base_install.sh when building the container image.

   This problem can’t be fixed (see below), so just use nproc for now.

   Other solutions would be bad:

   • Passing in the MAKEJOBS as a dockerfile env would create a new image if the number of tasks are changed, seems verbose and confusing.
   • Leaving master as-is would leave CPUs unused if there are more than 4.
2. 
   DrahtBot commented at 9:36 am on September 19, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28482 (ci: use LLVM/Clang 17 in tidy job by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Sep 19, 2023
4. maflcko force-pushed on Sep 19, 2023
5. DrahtBot added the label CI failed on Sep 19, 2023
6. maflcko force-pushed on Sep 19, 2023
7. DrahtBot removed the label CI failed on Sep 19, 2023
8. ci: Use nproc over MAKEJOBS in 01_base_install fa3b5e5e57
9. maflcko force-pushed on Sep 19, 2023
10. 
    fanquake commented at 4:16 pm on September 19, 2023: member

    Concept ACK
11. 
    theuni commented at 5:42 pm on September 19, 2023: member

    I assume I’m missing some context here, but ninja is parallel using cpu count by default. Do we really need to specify here -jFoo here? Or are we overriding to make it more parallel?
12. 
    maflcko commented at 9:21 pm on September 19, 2023: member

    Yeah, I kept it to be consistent with make below, but happy to drop it.
13. fanquake approved
14. 
    fanquake commented at 4:14 pm on September 20, 2023: member

    ACK - I think this is fine as-is, it’s an improvement over the current state fa3b5e5e57cd4649d577e06a3aca798b55a75fd5
15. fanquake merged this on Sep 20, 2023
16. fanquake closed this on Sep 20, 2023

    ---

17. Frank-GER referenced this in commit 244021e87d on Sep 25, 2023
18. sidhujag referenced this in commit fa58c720b2 on Sep 26, 2023
19. maflcko deleted the branch on Sep 29, 2023
20. bitcoin locked this on Sep 28, 2024

Contributors
maflcko DrahtBot fanquake theuni

Labels
Tests