ci: Install Homebrew's `pkg-config` package #28513

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:230920-ci-brew changing 1 files +1 −1

hebasto commented at 8:56 PM on September 20, 2023: member
Some versions of macOS images lack the pkg-config package.

For example, https://github.com/bitcoin/bitcoin/actions/runs/6248032071/job/16961797066:
```
Runner Image
  Image: macos-13
  Version: 20230417.1
```
```
+ ./autogen.sh
configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
```
This PR makes Homebrew install the pkg-config package explicitly.

Also please refer to macOS Build Guide.

ci: Install Homebrew's `pkg-config` package

Some versions of macOS images lack the 'pkg-config' package, which is
required for the build process.

43cd8029fa

DrahtBot commented at 8:56 PM on September 20, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK kevkevinpal, MarcoFalke, RandyMcMillan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Sep 20, 2023
in .github/workflows/ci.yml:71 in 43cd8029fa
```
  67 | @@ -68,7 +68,7 @@ jobs:
  68 |          run: clang --version
  69 |  
  70 |        - name: Install Homebrew packages
  71 | -        run: brew install boost libevent qt@5 miniupnpc libnatpmp ccache zeromq qrencode libtool automake gnu-getopt
  72 | +        run: brew install automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencode
```
kevkevinpal commented at 9:59 PM on September 20, 2023:

nit: not sure if you meant to reorder the packages for this diff, but would be a good chance to order alphabetically or by size of package

hebasto commented at 10:19 PM on September 20, 2023:

The new order is as follows: essential build tools, optional build tools, essential dependencies, optional dependencies.
kevkevinpal commented at 9:59 PM on September 20, 2023: contributor

ACK 43cd802
maflcko commented at 9:27 AM on September 21, 2023: member

lgtm ACK 43cd8029fa39e0bd4bf6fb896952952bcae16160
RandyMcMillan commented at 10:47 AM on September 21, 2023: contributor

ACK 43cd802
fanquake merged this on Sep 21, 2023
fanquake closed this on Sep 21, 2023
hebasto deleted the branch on Sep 21, 2023
Frank-GER referenced this in commit f2d88bcd86 on Sep 25, 2023
sidhujag referenced this in commit b9fc2d9682 on Sep 26, 2023
bitcoin locked this on Sep 20, 2024

Type	Reviewers
ACK	kevkevinpal, MarcoFalke, RandyMcMillan

Contributors

Labels

ci: Install Homebrew's `pkg-config` package #28513

Reviews