Make -checkpoints argument no longer debug-only #28524

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2023/09/look-mom-no-checkpoints changing 1 files +1 −1
  1. Sjors commented at 7:45 PM on September 23, 2023: member

    A small step towards dropping checkpoints entirely, make the option to disable them a bit easier to find.

    bitcoind --help
    ...
      -checkpoints
           Enable rejection of any forks from the known historical chain until
           block 295000 (default: 1)
    

    Before this PR this required bitcoind --help-debug.

    A potential next step could be to change the default to 0 in a future release, then drop the checkpoints in the next release (#28524) and then drop all the checkpoint code one release later.

  2. DrahtBot commented at 7:45 PM on September 23, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. fanquake commented at 12:24 PM on September 26, 2023: member

    make the option to disable them a bit easier to find.

    Not sure. If we aren't completely convinced about actually dropping them yet, I'm not sure that making the option more apparent to users is the right thing to do.

  4. Sjors marked this as a draft on Sep 27, 2023
  5. Sjors commented at 3:16 PM on September 27, 2023: member

    That makes sense. Marking this as draft until we feel confident enough to advertise this option. I've been running it for half a year :-)

  6. DrahtBot added the label CI failed on Jan 17, 2024
  7. Make -checkpoints argument no longer debug-only ffc604ed51
  8. Sjors force-pushed on Feb 13, 2024
  9. DrahtBot removed the label CI failed on Feb 13, 2024
  10. fanquake commented at 2:14 PM on March 6, 2024: member

    Closing for now. This is a simple change, but doesn't make sense yet, and can easily be reopened / redone once there is a clear path forward for #25725.

  11. fanquake closed this on Mar 6, 2024

  12. bitcoin locked this on Mar 6, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me