No description provided.
exclude CreatePidFile() function on WIN32 as it is unused #2855
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:guard_CreatePidFile changing 3 files +5 −1-
Diapolo commented at 8:32 AM on July 24, 2013: none
-
exclude CreatePidFile() function on WIN32 as it is unused a034c7ebb6
-
BitcoinPullTester commented at 9:00 AM on July 24, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a034c7ebb6995c342fea289d04a6198d793eab08 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 12:48 PM on July 24, 2013: none
This should fix problems some people with mingw-64 compilers have.
<pre> In file included from alert.h:13:0, from alert.cpp:11: util.h:211:57: error: 'pid_t' has not been declared void CreatePidFile(const boost::filesystem::path &path, pid_t pid); </pre>
I know error and fix seem not to match, but as we don't ever user CreatePidFile() on Windows it seems cleaner to avoid compilation of that function as to define pid_t for Windows.
-
sipa commented at 12:48 PM on July 24, 2013: member
ACK
- gavinandresen referenced this in commit e622f3f195 on Aug 5, 2013
- gavinandresen merged this on Aug 5, 2013
- gavinandresen closed this on Aug 5, 2013
- IntegralTeam referenced this in commit 241f76f9bf on Jun 4, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors