misc small changes to polish after include cleanup #3235

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:misc changing 7 files +14 −21

Diapolo commented at 3:22 PM on November 11, 2013: none

No description provided.
misc small changes to polish after include cleanup cd696e64df
laanwj commented at 3:46 PM on November 11, 2013: member

ACK (no code changes)
BitcoinPullTester commented at 4:07 PM on November 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/cd696e64dfe8821fe13d959dd2d1a2ee892f9155 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
wtogami commented at 8:24 PM on November 11, 2013: contributor

ACK
in src/util.h:None in cd696e64df
```
  26 | @@ -27,8 +27,6 @@
  27 |  #include <sys/resource.h>
  28 |  #include <sys/time.h>
  29 |  #include <sys/types.h>
  30 | -#else
  31 | -typedef int pid_t; /* define for Windows compatibility */
```
sipa commented at 11:41 PM on November 11, 2013:

Can we just delete this? Why was it there in the first place?

wtogami commented at 12:17 AM on November 12, 2013:

#2855 It was probably a historical hack to workaround this build failure. It does appear it can be removed now.

Diapolo commented at 7:19 AM on November 12, 2013:

As I compile on Windows and am not missing it I guess yes, it is safe. It's also only used in places guarded by #ifndef WIN32.

laanwj commented at 8:01 AM on November 12, 2013:

I added it back in the day to compile on MSVC. But even if someone were to repeat such a horrific thing, it's indeed not needed anymore as pid_t is only used in areas delimited by #ifdef WIN32.
laanwj referenced this in commit 309f783fce on Nov 12, 2013
laanwj merged this on Nov 12, 2013
laanwj closed this on Nov 12, 2013
Diapolo deleted the branch on Nov 12, 2013
Bushstar referenced this in commit 9378c271b6 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors