test: Add test case specific default wait timeout, use in feature_assumeutxo #28586

1. 
   fjahr commented at 2:37 pm on October 4, 2023: contributor

   This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.
2. test: Allow setting test case specific default wait timeout

   And use this in feature_assumeutxo.

   5f79d641ce
3. 
   DrahtBot commented at 2:37 pm on October 4, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Tests on Oct 4, 2023
5. 
   hebasto commented at 2:42 pm on October 4, 2023: member

   Fixes #28585

   This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.

   From this description it follows that #28585 was caused by “slow” CI environment. But timeout in 2400 seconds may point at some else roots of the problem.

6. fjahr renamed this:
   test: Fix assumeutxo timeout, add test case specific default wait timeout
   test: Add test case specific default wait timeout, use in feature_assumeutxo
   on Oct 4, 2023
7. 
   fjahr commented at 3:14 pm on October 4, 2023: contributor

   Fixes #28585 This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.

   From this description it follows that #28585 was caused by “slow” CI environment. But timeout in 2400 seconds may point at some else roots of the problem.

   Removed the fix note, #28589 is the actual fix

8. 
   fanquake commented at 3:29 pm on October 4, 2023: member

   Removed the fix note, #28589 is the actual fix

   Can this be closed then?

9. 
   fjahr commented at 3:42 pm on October 4, 2023: contributor

   I am closing this for now and will reopen if we see more timeouts occur. Could be that [the timeouts @achow101 reported](https://github.com/bitcoin/bitcoin/pull/27596#discussion_r1343167013) were related to #28589.
10. fjahr closed this on Oct 4, 2023

    ---

11. bitcoin locked this on Oct 3, 2024

Contributors
fjahr DrahtBot hebasto fanquake

Labels
Tests