This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to feature_assumeutxo which tends to timeout on slower machines.
test: Add test case specific default wait timeout, use in feature_assumeutxo #28586
pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:2023-10-au-fails changing 3 files +9 −2-
fjahr commented at 2:37 PM on October 4, 2023: contributor
-
5f79d641ce
test: Allow setting test case specific default wait timeout
And use this in feature_assumeutxo.
-
DrahtBot commented at 2:37 PM on October 4, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Tests on Oct 4, 2023
-
hebasto commented at 2:42 PM on October 4, 2023: member
Fixes #28585
This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to
feature_assumeutxowhich tends to timeout on slower machines.From this description it follows that #28585 was caused by "slow" CI environment. But timeout in 2400 seconds may point at some else roots of the problem.
- fjahr renamed this:
test: Fix assumeutxo timeout, add test case specific default wait timeout
test: Add test case specific default wait timeout, use in feature_assumeutxo
on Oct 4, 2023 -
fjahr commented at 3:14 PM on October 4, 2023: contributor
Fixes #28585 This adds the possibility of defining a default wait timeout for a whole functional test case. It then applies this to
feature_assumeutxowhich tends to timeout on slower machines.From this description it follows that #28585 was caused by "slow" CI environment. But timeout in 2400 seconds may point at some else roots of the problem.
Removed the fix note, #28589 is the actual fix
-
fjahr commented at 3:42 PM on October 4, 2023: contributor
I am closing this for now and will reopen if we see more timeouts occur. Could be that the timeouts [@achow101](/bitcoin-bitcoin/contributor/achow101/) reported were related to #28589.
- fjahr closed this on Oct 4, 2023
- bitcoin locked this on Oct 3, 2024