kernel: chainparams updates for 26.x

fanquake commented at 4:19 pm on October 4, 2023: member

Update chainparams pre 26.x branch off.

Note: Remember that some variance is expected in the m_assumed_* sizes.

Closes #28572.

fanquake added this to the milestone 26.0 on Oct 4, 2023

DrahtBot commented at 4:19 pm on October 4, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	Sjors, ajtowns, darosior

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#26201 (Remove Taproot activation height by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Validation on Oct 4, 2023

ajtowns commented at 10:59 pm on October 4, 2023: contributor

ACK 817c7cd020c8e4a7e1787bce2e1a2f1d11e91b5f

Consider merging #25970 first and also doing the steps there, perhaps? Can easily be deferred ’til after branch off and next release though.

Sjors approved

Sjors commented at 10:27 am on October 5, 2023: member

ACK 817c7cd020c8e4a7e1787bce2e1a2f1d11e91b5f

See release-process.md for how to verify these numbers.

kernel: update nMinimumChainWork & defaultAssumeValid for 26.x a9d070a6f8

kernel: update chainTxData for 26.x a8c2e5e556

kernel: update m_assumed_* chain params for 26.x f12f92b813

headerssync: update params for 26.x b2ede22395

fanquake force-pushed on Oct 5, 2023

fanquake commented at 10:41 am on October 5, 2023: member

Consider merging #25970 first and also doing the steps there, perhaps?

Incorporated this. We haven’t changed the values since the initial merge. Updating now seems ok.

maflcko commented at 11:35 am on October 5, 2023: member

nit: Could update https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off to bump the example pull to https://github.com/bitcoin/bitcoin/pull/28591, as the process now includes a new step?

fanquake commented at 12:41 pm on October 5, 2023: member

nit: Could update https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off to bump the example pull

Included this now.

darosior commented at 1:58 pm on October 5, 2023: member

ACK 100b7c9b6713aa32281077b0bed6d8daecdc20be – only checked assumevalid and minimum chain work, not header sync params.

 0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3ACK 100b7c9b6713aa32281077b0bed6d8daecdc20be
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmUev50ACgkQ4T/BRc0/
 7QwQdJAwAn3XQZUXme0XNbEob00a0VxY+xz+rt2aT3JZM8Jmm9OnDDJb4oZVD85wf
 8PyhNLj9jWwa2GXoyHLkSkpl27c5uY820x1cte6roAXDCoF/SfhK2nE34UmShAhvF
 99avwg+wjDd5WAGcK1bcq6E0+ko27VbfMaETvRl3BueafFBIo9yKACJQMfAhVk9vC
10WbJOTGol7xp0GELsGjUjfYz3G3Nr36UCUG4fcBuBJljwH8C72Axw0ozCtvS+cyH6
11UDEaTvElgcQGKoz1ippf+hQU/VhuiXSMiOuhdrhujsOHduC3hLPECR8r/w/24P54
12WcENv8+d3BeP7VGPIhLIwX2V5jTEdxUSg55igUgP7HvQ/xyzNQQ+5Cgo59T5xhIg
13ICVT04k2F9zlqEskfGzuGZ0WbpUL6aKqHCpeLeZPhu6gi/bO8ndJ3IEM7o9jrtZz
14Va/tAAI+zH4otEeKz7ooEjDCKWGGY0vjLG8kzycfpD6aHDnKoP42gtP+QnPhBHDQ
15BzkXTbUa
16=YcGc
17-----END PGP SIGNATURE-----

DrahtBot requested review from ajtowns on Oct 5, 2023

DrahtBot requested review from Sjors on Oct 5, 2023

doc: update example pulls in release-process.md bd71f03df7

Sjors commented at 3:04 pm on October 5, 2023: member

ACK 100b7c9b6713aa32281077b0bed6d8daecdc20be

Also ran the headerssync-params.py script.

DrahtBot removed review request from Sjors on Oct 5, 2023

fanquake force-pushed on Oct 5, 2023

Sjors commented at 3:10 pm on October 5, 2023: member

re-ACK bd71f03df75d2c17926b6d575ffa886daa334e3a

 0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA256
 2
 3ACK bd71f03df75d2c17926b6d575ffa886daa334e3a
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQIzBAEBCAAdFiEE7ZvfetalXiMuhFJCV/+b28wwEAkFAmUe0bIACgkQV/+b28ww
 7EAnC+g//fQtsgMpE9/52FLHyRWrlKuFf6edCPhrWHKPC+/0bd2yYugxCb1zK0XeN
 8yjXWl/OfO8TXijla/egTz/3xWKWQMz9zHIdEISZyvBaIpCW2wBZWVWEUEj2Co84Z
 9LpNvazgH1xfKka0j9SOysJ1lP60UPtoxlpBDR2GguwpYtg3UiciXJIy/HoxY7sPT
10IeJRAegrflAk5mgUqqiKuhwGnW/cwASdzeZ8i6vRjbxbrgcaEPaEY3SW4QWQm7es
11KjGm1rWTjigYWg4V6tG65mdL06nDxafo1TaacJgzMq/lDYMRzcdztl63T/BwyeJH
12GDRfdt/5ASq71vQOk92b2//wEhRdCnLExon2htJZB+JLCEEgtuhdqSDBWVf6MSiQ
13dvARe8JiRv8AkYaFWdKe1que04o4jxGr9+Bd2cYrI+3h6wCgc+QCYhj+qMuFhyep
14R7gK4STbXtBKqDknJJTw4YUCqzElfKHJwxpKzh0z8uQNmVXKyDw6NxCF4ci/fMqo
158nsTsjNSV9imeP3EG2//svbL95ujRI0GKHX2W2j/IP9SodAelJ/v7reGmRk7+crv
16+EBR+Oy1DAzpa2tGQheoFPFVQwputbmjQ63oRXjq8WhoUrioL7IonipzkHjCuTFM
17Ugu9Pqk7Cj4EzO0X3yH1KI79XwuJ9Te3siMuDC/S/IApB7vgxrM=
18=nzCo
19-----END PGP SIGNATURE-----

DrahtBot requested review from darosior on Oct 5, 2023

ajtowns commented at 6:48 pm on October 5, 2023: contributor

reACK bd71f03df75d2c17926b6d575ffa886daa334e3a

DrahtBot removed review request from ajtowns on Oct 5, 2023

darosior commented at 1:55 pm on October 8, 2023: member

re-ACK bd71f03df75d2c17926b6d575ffa886daa334e3a for assumevalid and minchainwork params.

 0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3ACK bd71f03df75d2c17926b6d575ffa886daa334e3a
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmUitIYACgkQ4T/BRc0/
 7QwQSKwwA2pX153WNmI8Aws8DVmyxEG6UVI7BbFYfklr0k4qnPB5CAeFGrtON1PVu
 86yljNp7tD297AsQ/kUBL1Vsw+PFy3Oq7PRDruCQJm4iwRGyI7a6WCHzP3hMqiZB5
 9LmMtoTzW3XUJuarbAK5bK53MUYnbmKPsYYzpFfVPfDajr+RzJv5I2WOBNWZTJDgV
10L+kpcbKhVldp46MGa7XtTVH6mvChqgEaa0wHVCuhXf+l2IOAw+1GamOjTlIcnQy5
11CCJUArHhHIJN0QvEdgFsuCoqvSX+3OGO8CA5nXpkWTfS0iUSyCF20b7yINxXb4f6
125PmnSEeyfWUYsH7gP7t7MJ9sYzSYUGYMgAXcYzOgaUsGa4fdfbcPPREN0CrhELVl
13XkYU2nAMIX+p3PL4yqWM6gbQgHYdQoSk8G2VJ/v3HJasqpfUWlCcJpf3D5xODg1T
14LZDhhz8BjzEfsi8UmPe+E5gx47vdQ9YNciu+Bjmlm/Z5TcElhIQjH3vp6fQWF22y
155pvjxLWI
16=YXBD
17-----END PGP SIGNATURE-----

DrahtBot removed review request from darosior on Oct 8, 2023

fanquake merged this on Oct 9, 2023

fanquake closed this on Oct 9, 2023

fanquake deleted the branch on Oct 9, 2023

kernel: chainparams updates for 26.x #28591

Code Coverage

Reviews

Conflicts