test: unlocked wallet context manager #28601

issue maflcko openend this issue on October 5, 2023
  1. maflcko commented at 3:45 pm on October 5, 2023: member

    Motivation

    Currently tests with a locked wallet have to verbosely specify a long timeout and then lock the wallet again, once they are done testing the unlocked part. This is fragile, because the wallet may lock earlier, or the dev may forget to re-lock the wallet when done.

    All issues should be fixed with a context manager.

    Possible solution

    A context manager. See also #28403 (review)

    Useful Skills

    • Compiling Bitcoin Core from source
    • Running the C++ unit tests and the Python functional tests
    • Python 3 contextlib

    Guidance for new contributors

    Want to work on this issue?

    For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

  2. maflcko added the label good first issue on Oct 5, 2023
  3. maflcko added the label Tests on Oct 5, 2023
  4. BrandonOdiwuor commented at 5:12 am on October 9, 2023: contributor
    @maflcko would love to work on this
  5. fanquake closed this on Oct 19, 2023

  6. Julio-Rats referenced this in commit 091d29c495 on Jan 26, 2024
  7. bitcoin locked this on Oct 18, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me