test: make test_utxo_snapshots.sh use signet #28619

issue Sjors openend this issue on October 9, 2023
  1. Sjors commented at 1:13 pm on October 9, 2023: member

    It currently requires recompiling, which doesn’t seem necessary if we just use a lighter weight network like signet.

    We could also drop this script entirely?

  2. Sjors commented at 1:13 pm on October 9, 2023: member

    cc @jamesob do you think it’s still useful?

    If so I’ll look into switching it to Signet.

  3. maflcko added the label Brainstorming on Oct 9, 2023
  4. maflcko added the label Tests on Oct 9, 2023
  5. maflcko commented at 8:32 am on October 10, 2023: member
    I’d say for testing, the existing unit or functional test framework should be used. No objection for the bash script to exist, but I think longer term, it is clear that bash scripts won’t be maintained in this repo, given that there are no reviewers for them and that the script is excluded from shellcheck completely (https://github.com/bitcoin/bitcoin/pull/27596#discussion_r1344725060). Unit and functional test would at least run in the CI.
  6. fanquake commented at 10:37 am on March 7, 2024: member
    Going to close this, given we should be removing the bash scripts in #29553.
  7. fanquake closed this on Mar 7, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me