ci: Install Qt's default Android API platform #28633

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:231010-android changing 1 files +1 −1
  1. hebasto commented at 6:46 PM on October 10, 2023: member

    When building the qt package, it expects that the default (in Qt's view) Android API platform is installed.

    During the recent Qt version update, it has been changed:

    --- a/mkspecs/features/android/sdk.prf
    +++ b/mkspecs/features/android/sdk.prf
    @@ -1,6 +1,6 @@
     API_VERSION_TO_USE = $$(ANDROID_API_VERSION)
     isEmpty(API_VERSION_TO_USE): API_VERSION_TO_USE = $$API_VERSION
    -isEmpty(API_VERSION_TO_USE): API_VERSION_TO_USE = android-28
    +isEmpty(API_VERSION_TO_USE): API_VERSION_TO_USE = android-31
     
     ANDROID_JAR_FILE = $$ANDROID_SDK_ROOT/platforms/$$API_VERSION_TO_USE/android.jar
     !exists($$ANDROID_JAR_FILE) {
    

    This PR fixes the CI for the Android task and addresses #28561 (comment).

    Qt docs still claim that Android API Level 21 and up are supported, however, I did not test every possible configuration.

    NOTE: #28611 is still valid.

  2. ci: Install Android API 31 platform as Qt expects 78d3062b68
  3. DrahtBot commented at 6:46 PM on October 10, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, jarolrod

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Oct 10, 2023
  5. maflcko added this to the milestone 26.0 on Oct 11, 2023
  6. maflcko commented at 11:33 AM on October 11, 2023: member

    lgtm ACK 78d3062b68988f5094c61a845be756788933c752

    I may test after merge

  7. jarolrod commented at 4:21 AM on October 12, 2023: member

    tACK 78d3062b68988f5094c61a845be756788933c752

  8. fanquake merged this on Oct 12, 2023
  9. fanquake closed this on Oct 12, 2023

  10. hebasto deleted the branch on Oct 12, 2023
  11. Frank-GER referenced this in commit 566839dec4 on Oct 13, 2023
  12. bitcoin locked this on Oct 11, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me