test: Fuzz merge with -use_value_profile=0 for now #28644

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2310-fuzz-less-value- changing 1 files +6 −2
  1. maflcko commented at 2:54 pm on October 12, 2023: member

    Seems odd that this has to be done, but for now there are (unknown) size limits on the qa-assets repo. Also, a larger size means that cloning and iterating over the files takes a longer time.

    Not sure how to measure the net impact of this, but with some backups reverting this commit, it can be limited on the downside?

  2. test: Fuzz merge with -use_value_profile=0 for now faa190b1ef
  3. DrahtBot commented at 2:54 pm on October 12, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Oct 12, 2023
  5. maflcko requested review from dergoegge on Oct 12, 2023
  6. maflcko added the label Brainstorming on Oct 12, 2023
  7. maflcko requested review from murchandamus on Oct 12, 2023
  8. dergoegge approved
  9. dergoegge commented at 2:57 pm on October 12, 2023: member

    ACK faa190b1efbdfdb9b12a7bfa7f732b5471a02e64

    In the long run we should find a more scalable solution than a git repo for our corpora and re-enable this.

  10. dergoegge commented at 3:07 pm on October 12, 2023: member

    Not sure how to measure the net impact of this, but with some backups reverting this commit, it can be limited on the downside?

    I think oss-fuzz maintains an internal corpus that includes the use_value_profile feature inputs, so the downside (in terms of not finding bugs) should be pretty minimal.

  11. maflcko commented at 8:04 pm on October 12, 2023: member
    The red CI task can be ignored.
  12. fanquake merged this on Oct 13, 2023
  13. fanquake closed this on Oct 13, 2023

  14. maflcko deleted the branch on Oct 13, 2023
  15. Frank-GER referenced this in commit d7323f8dbe on Oct 13, 2023
  16. murchandamus commented at 7:05 pm on October 13, 2023: contributor
    Post-merge ACK faa190b1efbdfdb9b12a7bfa7f732b5471a02e64

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 07:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me