addrman: log AS only when using asmap #28729

1. 
   brunoerg commented at 12:19 pm on October 25, 2023: contributor

   This PR changes the log to just print the ASN when using asmap, same logic presented in other logs:

   https://github.com/bitcoin/bitcoin/blob/afa081a39bde77d3959aa35b6e6c75a2fe988d68/src/net_processing.cpp#L3552-L3556

   https://github.com/bitcoin/bitcoin/blob/afa081a39bde77d3959aa35b6e6c75a2fe988d68/src/net_processing.cpp#L3598-L3604

2. 
   DrahtBot commented at 12:19 pm on October 25, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	naumenkogs, mzumsande
   Stale ACK	sipa

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label P2P on Oct 25, 2023
4. 
   maflcko commented at 12:25 pm on October 25, 2023: member

   Can you share an example log before and after?
5. 
   brunoerg commented at 12:42 pm on October 25, 2023: contributor

   Can you share an example log before and after?

   This PR (without asmap): [addrman] Added 172.56.55.248:8333 to new[401][28]

   master (without asmap): [addrman] Added 172.56.55.248:8333 mapped to AS0 to new[401][28]

6. brunoerg force-pushed on Oct 25, 2023
7. DrahtBot added the label CI failed on Oct 25, 2023
8. DrahtBot removed the label CI failed on Oct 25, 2023
9. 
   naumenkogs commented at 10:44 am on October 27, 2023: member

   ACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a No need to print a confusing mapped-nothing. Hopefully, we don’t break much log-parsers.
10. 
    sipa commented at 1:47 pm on October 28, 2023: member

    utACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a
11. 
    mzumsande commented at 7:01 pm on October 30, 2023: contributor

    Concept ACK

    Would be good to do the same thing to the log in AddrManImpl::Good_().

12. 
    brunoerg commented at 9:45 pm on October 30, 2023: contributor

    Would be good to do the same thing to the log in AddrManImpl::Good_().

    Nice find, addressing it.

13. addrman: log AS only when using asmap 02a4f1a385
14. brunoerg force-pushed on Oct 30, 2023
15. 
    brunoerg commented at 11:20 pm on October 30, 2023: contributor

    Force-pushed changing the log in AddrManImpl::Good_().
16. 
    naumenkogs commented at 7:29 am on October 31, 2023: member

    ACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
17. DrahtBot requested review from sipa on Oct 31, 2023
18. DrahtBot requested review from mzumsande on Oct 31, 2023
19. 
    mzumsande commented at 8:57 pm on October 31, 2023: contributor

    Code Review ACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
20. DrahtBot removed review request from mzumsande on Oct 31, 2023
21. fanquake merged this on Nov 1, 2023
22. fanquake closed this on Nov 1, 2023

    ---

23. bitcoin locked this on Oct 31, 2024

Contributors
brunoerg DrahtBot maflcko naumenkogs sipa mzumsande

Review Requested
sipa

Labels
P2P