This PR changes the log to just print the ASN when using asmap, same logic presented in other logs:
addrman: log AS only when using asmap #28729
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-10-addrman-log-as changing 2 files +7 −5-
brunoerg commented at 12:19 pm on October 25, 2023: contributor
-
DrahtBot commented at 12:19 pm on October 25, 2023: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK naumenkogs, mzumsande Stale ACK sipa If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label P2P on Oct 25, 2023
-
maflcko commented at 12:25 pm on October 25, 2023: memberCan you share an example log before and after?
-
brunoerg commented at 12:42 pm on October 25, 2023: contributor
Can you share an example log before and after?
This PR (without asmap):
[addrman] Added 172.56.55.248:8333 to new[401][28]
master (without asmap):
[addrman] Added 172.56.55.248:8333 mapped to AS0 to new[401][28]
-
brunoerg force-pushed on Oct 25, 2023
-
DrahtBot added the label CI failed on Oct 25, 2023
-
DrahtBot removed the label CI failed on Oct 25, 2023
-
naumenkogs commented at 10:44 am on October 27, 2023: memberACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a No need to print a confusing
mapped
-nothing. Hopefully, we don’t break much log-parsers. -
sipa commented at 1:47 pm on October 28, 2023: memberutACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a
-
mzumsande commented at 7:01 pm on October 30, 2023: contributor
Concept ACK
Would be good to do the same thing to the log in
AddrManImpl::Good_()
. -
brunoerg commented at 9:45 pm on October 30, 2023: contributor
Would be good to do the same thing to the log in AddrManImpl::Good_().
Nice find, addressing it.
-
addrman: log AS only when using asmap 02a4f1a385
-
brunoerg force-pushed on Oct 30, 2023
-
brunoerg commented at 11:20 pm on October 30, 2023: contributorForce-pushed changing the log in
AddrManImpl::Good_()
. -
naumenkogs commented at 7:29 am on October 31, 2023: memberACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
-
DrahtBot requested review from sipa on Oct 31, 2023
-
DrahtBot requested review from mzumsande on Oct 31, 2023
-
mzumsande commented at 8:57 pm on October 31, 2023: contributorCode Review ACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
-
DrahtBot removed review request from mzumsande on Oct 31, 2023
-
fanquake merged this on Nov 1, 2023
-
fanquake closed this on Nov 1, 2023
-
bitcoin locked this on Oct 31, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-11 06:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-11 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me