addrman: log AS only when using asmap #28729

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-10-addrman-log-as changing 2 files +7 −5

brunoerg commented at 12:19 PM on October 25, 2023: contributor

This PR changes the log to just print the ASN when using asmap, same logic presented in other logs:

https://github.com/bitcoin/bitcoin/blob/afa081a39bde77d3959aa35b6e6c75a2fe988d68/src/net_processing.cpp#L3552-L3556

https://github.com/bitcoin/bitcoin/blob/afa081a39bde77d3959aa35b6e6c75a2fe988d68/src/net_processing.cpp#L3598-L3604
DrahtBot commented at 12:19 PM on October 25, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK naumenkogs, mzumsande

Stale ACK sipa

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label P2P on Oct 25, 2023
maflcko commented at 12:25 PM on October 25, 2023: member

Can you share an example log before and after?
brunoerg commented at 12:42 PM on October 25, 2023: contributor

Can you share an example log before and after?

This PR (without asmap): [addrman] Added 172.56.55.248:8333 to new[401][28]

master (without asmap): [addrman] Added 172.56.55.248:8333 mapped to AS0 to new[401][28]
brunoerg force-pushed on Oct 25, 2023
DrahtBot added the label CI failed on Oct 25, 2023
DrahtBot removed the label CI failed on Oct 25, 2023
naumenkogs commented at 10:44 AM on October 27, 2023: member

ACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a No need to print a confusing mapped-nothing. Hopefully, we don't break much log-parsers.
sipa commented at 1:47 PM on October 28, 2023: member

utACK 3e3f5ddb9a8ac27ea509fe3dd09b783472c1ce9a
mzumsande commented at 7:01 PM on October 30, 2023: contributor

Concept ACK

Would be good to do the same thing to the log in AddrManImpl::Good_().
brunoerg commented at 9:45 PM on October 30, 2023: contributor

Would be good to do the same thing to the log in AddrManImpl::Good_().

Nice find, addressing it.
addrman: log AS only when using asmap 02a4f1a385
brunoerg force-pushed on Oct 30, 2023
brunoerg commented at 11:20 PM on October 30, 2023: contributor

Force-pushed changing the log in AddrManImpl::Good_().
naumenkogs commented at 7:29 AM on October 31, 2023: member

ACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
DrahtBot requested review from sipa on Oct 31, 2023
DrahtBot requested review from mzumsande on Oct 31, 2023
mzumsande commented at 8:57 PM on October 31, 2023: contributor

Code Review ACK 02a4f1a3859ed7e865641b35ca1bc9ce711e696f
DrahtBot removed review request from mzumsande on Oct 31, 2023
fanquake merged this on Nov 1, 2023
fanquake closed this on Nov 1, 2023
bitcoin locked this on Oct 31, 2024