Inside a lambda, __func__ will evaluate to something like "operator()". Fix this by either removing it, or by using the real name.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone/lambda-function-name.html
doc: Fix bugprone-lambda-function-name errors #28737
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2310-bugprone-lambda-function-name- changing 4 files +25 −19-
maflcko commented at 3:05 PM on October 26, 2023: member
-
faa769db5a
Fix bugprone-lambda-function-name errors
Can be reviewed with --color-moved=dimmed-zebra
-
DrahtBot commented at 3:05 PM on October 26, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK TheCharlatan, darosior If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28676 ([WIP] Cluster mempool implementation by sdaftuar)
- #28391 (refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access by TheCharlatan)
- #28335 (RFC: Remove boost usage from kernel api / headers by TheCharlatan)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- maflcko renamed this:
Fix bugprone-lambda-function-name errors
doc: Fix bugprone-lambda-function-name errors
on Oct 26, 2023 - DrahtBot added the label Docs on Oct 26, 2023
- Thompson1985 approved
- TheCharlatan approved
-
TheCharlatan commented at 11:09 AM on October 30, 2023: contributor
ACK faa769db5a4c16fd171e9a39c33e245db4e7c134
- fanquake requested review from darosior on Oct 30, 2023
-
darosior commented at 12:56 PM on October 30, 2023: member
utACK faa769db5a4c16fd171e9a39c33e245db4e7c134
- fanquake merged this on Oct 30, 2023
- fanquake closed this on Oct 30, 2023
- maflcko deleted the branch on Oct 30, 2023
- bitcoin locked this on Oct 29, 2024
Contributors
Labels