refactor: Add LIFETIMEBOUND to all (w)txid getters #28740

1. 
   maflcko commented at 10:54 am on October 27, 2023: member

   Currently some getters return a reference, some don’t. Fix this by returning a reference everywhere. Also, add LIFETIMEBOUND to all. Then, use the compiler warnings to create copies only where needed.

   Also, fix iwyu includes while touching the includes.

2. 
   DrahtBot commented at 10:54 am on October 27, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, stickies-v, pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
   • #27286 (wallet: Keep track of the wallet’s own transaction outputs in memory by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Refactoring on Oct 27, 2023
4. refactor: Add LIFETIMEBOUND to all (w)txid getters

   Then, use the compiler warnings to create copies only where needed.
   
   Also, fix iwyu includes while touching the includes.

   faec889f93
5. maflcko force-pushed on Oct 27, 2023
6. dergoegge approved
7. 
   dergoegge commented at 12:39 pm on October 27, 2023: member

   Code review ACK faec889f938f90e0b887426db27a15ec0d169399
8. stickies-v approved
9. 
   stickies-v commented at 2:08 pm on October 27, 2023: contributor

   ACK faec889f938f90e0b887426db27a15ec0d169399
10. pablomartin4btc approved
11. 
    pablomartin4btc commented at 0:19 am on October 28, 2023: member

    cr ACK faec889f938f90e0b887426db27a15ec0d169399

    I’ve checked other PRs where this refactoring has been also achieved (#22278, #25060, #25967) and developers notes regarding the use of LIFETIMEBOUND.

12. fanquake merged this on Oct 29, 2023
13. fanquake closed this on Oct 29, 2023

    ---

14. maflcko deleted the branch on Oct 29, 2023

Contributors
maflcko DrahtBot dergoegge stickies-v pablomartin4btc

Labels
Refactoring