[26.x] Backports for rc2

fanquake commented at 1:25 pm on October 30, 2023: member

Backports for v26.0rc2:

fanquake added this to the milestone 26.0 on Oct 30, 2023

DrahtBot commented at 1:25 pm on October 30, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, TheCharlatan, josibake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Backport on Oct 30, 2023

josibake commented at 1:36 pm on October 30, 2023: member

ACK https://github.com/bitcoin/bitcoin/pull/28754/commits/6772a6272129629659e66d245d1911420a3a72ac

Pulls in the correct commit for the bugfix, compiled without any issues so seems fine to leave off the IWYU commit from https://github.com/bitcoin/bitcoin/pull/28728

bugfix: Mark CNoDestination and PubKeyDestination constructor explicit

This should fix the bug reported in
https://github.com/bitcoin/bitcoin/pull/28246#discussion_r1371640502,
which caused the GUI to not detect the destination type of recipients,
thus picking the wrong change destination type.

Also, add missing lifetimebound attribute to a getter method.

GitHub-Pull: #28728
Rebased-From: 1111475b41698260cda0f25a96c051fd18d66129

6544ffa01f

[net] Check i2p private key constraints

Co-authored-by: Vasil Dimov <vd@FreeBSD.org>

GitHub-Pull: #28695
Rebased-From: cf70a8d56510a5f07eff0fd773184cae14b2dcc9

1f11784aac

[test] Test i2p private key constraints

Github-Pull: #28695
Rebased-From: 5cf4d266d9b1e7bd9394e7581398de5bc540ae99

d3ebf6e9fc

assumeutxo, blockstorage: prevent core dump on invalid hash

Github-Pull: #28698
Rebased-from: 4a5be10b928d4ed33d223972537c1cb79163e79c

b761a58171

test: add coverage for snapshot chainstate not matching AssumeUTXO parameters

Co-authored-by: Russell Yanofsky <russ@yanofsky.org>
Co-authored-by: Sebastian Falbesoner <sebastian.falbesoner@gmail.com>

Github-Pull: #28698
Reabsed-From: 811067ca1cbbd4a697791cbe3ecd4bee19fe6193

fe57abd7e9

guix: Zip needs to include all files with time as SOURCE_DATE_EPOCH

The zip for codesigned MacOS distribution needs to have all files have
the same timestamp. These files also need to be included in the zip as
zip is not automatically recursive. We use the same pattern for zip as
is done for the other zip files produced by guix.

Github-Pull: #28757
Rebased-From: f6f18eeaa88784e487e9bca8c5ace6c66bd721cc

deccc50631

guix: update signapple

Fixes #28449

Github-Pull: #28759
Rebased-From: 79539fbfbf4d09a8b4861ddcba5b194297bc1b65

05e8874554

fanquake force-pushed on Oct 31, 2023

fanquake marked this as ready for review on Oct 31, 2023

fanquake commented at 5:16 pm on October 31, 2023: member

Added final backports, and bumped version + manpages. We also just merged a translation update, which I rebased this branch on top of.

hebasto approved

hebasto commented at 7:58 pm on October 31, 2023: member

ACK 9c29048dac5dfa5a06323b350156b1212b87d56d, I’ve applied backport locally and got a zero diff. Also I’ve reviewed the last two commits.

DrahtBot requested review from josibake on Oct 31, 2023

TheCharlatan approved

TheCharlatan commented at 8:11 pm on October 31, 2023: contributor

lgtm ACK 9c29048dac5dfa5a06323b350156b1212b87d56d

gui: fix crash on selecting "Mask values" in transaction view

This commits fixes a crash bug that can be caused with the following steps:
- change to the "Transactions" view
- right-click on an arbitrary transaction -> "Show transaction details"
- close the transaction detail window again
- select "Settings" -> "Mask values"

The problem is that the list of opened dialogs, tracked in the member
variable `m_opened_dialogs`, is only ever appended with newly opened
transaction detail dialog pointers, but never removed. This leads to
dangling pointers in the list, and if the "Mask values" menu item is
selected, a crash is caused in the course of trying to close the opened
transaction detail dialogs (see `closeOpenedDialogs()` method). Fix this
by removing the pointer from the list if the corresponding widget is
destroyed.

Github-Pull: https://github.com/bitcoin-core/gui/pull/774
Rebased-From: e26e665f9f64a962dd56053be817cc953e714847

e097d4cb53

build: bump version to v26.0rc2 0b189a9092

doc: update manual pages for v26.0rc2 e4e84790f6

fanquake force-pushed on Nov 1, 2023

hebasto approved

hebasto commented at 10:04 am on November 1, 2023: member

re-ACK e4e84790f62990f31a519f1ec0e8cc16e93a3c3b, only a backport of https://github.com/bitcoin-core/gui/pull/774 added since my recent review.

DrahtBot requested review from TheCharlatan on Nov 1, 2023

TheCharlatan approved

TheCharlatan commented at 10:10 am on November 1, 2023: contributor

Re-ACK e4e84790f62990f31a519f1ec0e8cc16e93a3c3b

josibake commented at 10:23 am on November 1, 2023: member

ACK https://github.com/bitcoin/bitcoin/commit/e4e84790f62990f31a519f1ec0e8cc16e93a3c3b

DrahtBot removed review request from josibake on Nov 1, 2023

fanquake merged this on Nov 1, 2023

fanquake closed this on Nov 1, 2023

fanquake deleted the branch on Nov 1, 2023

[26.x] Backports for rc2 #28754

Code Coverage

Reviews