guix: update signapple to latest master

fanquake commented at 11:40 am on October 31, 2023: member

Fixes #28449, and removes the need to boostrap Rust, by avoiding the python-requests dependency.

Comparing a --no-substitutes build of this PR, to master, signapple requires ~1350 less packages to boostrap: Master derivation - https://gist.github.com/fanquake/dbf69a62c9a78b7ae8c183a160e6d58d PR derivation - https://gist.github.com/fanquake/0aa2d8eddaba861ba489ed3d936f727d

DrahtBot commented at 11:40 am on October 31, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	achow101
Concept ACK	hebasto, laanwj, darosior

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28580 (guix: update time-machine by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Oct 31, 2023

hebasto commented at 11:46 am on October 31, 2023: member

Concept ACK.

laanwj commented at 1:44 pm on October 31, 2023: member

Fixes #28449, and removes the need to boostrap Rust, by avoiding the python-requests dependency.

Reducing the bootstrapping footprint is great. concept ACK.

guix: update signapple

Fixes #28449

79539fbfbf

fanquake force-pushed on Oct 31, 2023

fanquake marked this as ready for review on Oct 31, 2023

fanquake commented at 3:16 pm on October 31, 2023: member

The difference in bootstrapping is significant enough, that I’d also like to backport this to the 26.x branch. cc @theuni @darosior.

achow101 added this to the milestone 26.0 on Oct 31, 2023

achow101 added the label Needs backport (26.x) on Oct 31, 2023

darosior commented at 4:03 pm on October 31, 2023: member

Concept ACK.

fanquake commented at 4:17 pm on October 31, 2023: member

Guix Build (aarch64):

 066c24a02462fa98aa772a7347bfa5edd64f79979e256b463cdc82808a74dc38e  guix-build-79539fbfbf4d/output/aarch64-linux-gnu/SHA256SUMS.part
 1bf0e04a6dfc8d580428c8e33eedb57f2ec311eff054387dac985abc1e2c50a3a  guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu-debug.tar.gz
 24e9d47a41bfd12f3aa5bb553b162a348359b289a4d1eeb0ce83029852bf66036  guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu.tar.gz
 3e912a655d033eb003f21b87a915106805446f821cdb76054319a7faa27414fb8  guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/SHA256SUMS.part
 49011963ba8bb4031f70e2e0aa61bf83c541a214b1a2c16c7af028a1c6cce7b46  guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/bitcoin-79539fbfbf4d-arm-linux-gnueabihf-debug.tar.gz
 59f5517fe519f401c4f5c56ca803757e88fde39592b0953f2ba629b29a0e62822  guix-build-79539fbfbf4d/output/arm-linux-gnueabihf/bitcoin-79539fbfbf4d-arm-linux-gnueabihf.tar.gz
 65ea366688e718b729dcdc9905ceb6a70fd450ee620a86fe3a2e2bf5e4a3db6ab  guix-build-79539fbfbf4d/output/arm64-apple-darwin/SHA256SUMS.part
 792ec16c059494878935b58536d34388c0e6a8fda8a88e2f794e369b31e509004  guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin-unsigned.tar.gz
 8fc73e7e4fa24a2777a4c01980eb3b8136990073232aa929bbb20080a546b37a2  guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin-unsigned.zip
 935fd97bef578b0843e11e91a1d0e7c5121768e6659fc69cd32be558196bed81d  guix-build-79539fbfbf4d/output/arm64-apple-darwin/bitcoin-79539fbfbf4d-arm64-apple-darwin.tar.gz
10c725d9cff5d6898c144deb6d302655211e7069a55cd103968212785c73f2065a  guix-build-79539fbfbf4d/output/dist-archive/bitcoin-79539fbfbf4d.tar.gz
11559f9e373ea4adaf59422ca9e9546e7661d86aa5cb793aac71cebb080c6a23c3  guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/SHA256SUMS.part
1238b93171d4542a25c3974604030352ad73eb053304681542599fee0d3fa29a4e  guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/bitcoin-79539fbfbf4d-powerpc64-linux-gnu-debug.tar.gz
134cd8da21bb9831cdb8d3bf359d6eb41a67f9a57b213375900ae127bd4b053aa2  guix-build-79539fbfbf4d/output/powerpc64-linux-gnu/bitcoin-79539fbfbf4d-powerpc64-linux-gnu.tar.gz
14aa2fc1295460b1886fbacb23083d8204d708f25739f573a20eab8f7374defa21  guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/SHA256SUMS.part
15549650d52b3d6be0d001fbca419eaf9ba87be7fe59de1e1509b169d18f33327b  guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/bitcoin-79539fbfbf4d-powerpc64le-linux-gnu-debug.tar.gz
1695d83d7a418f3b9d67d45e57d282ceda65a7646407b3bf71801e6ca414fa48c9  guix-build-79539fbfbf4d/output/powerpc64le-linux-gnu/bitcoin-79539fbfbf4d-powerpc64le-linux-gnu.tar.gz
17a96ee13a6b0cf91ca891d1577ead2d4662c9297d6f82f03d69da72ab04f31721  guix-build-79539fbfbf4d/output/riscv64-linux-gnu/SHA256SUMS.part
184d878e16999b4d36638630740b25c18a7ffdaf9329003846297ab278b7b5209b  guix-build-79539fbfbf4d/output/riscv64-linux-gnu/bitcoin-79539fbfbf4d-riscv64-linux-gnu-debug.tar.gz
195cd87541a02f2319bd31dcba29e51e716362b803111f04d716af6e50694b01cf  guix-build-79539fbfbf4d/output/riscv64-linux-gnu/bitcoin-79539fbfbf4d-riscv64-linux-gnu.tar.gz
20f127dc1444ae23755d2cb4729d995669c5473e7933f5c16e094425218c7cf50a  guix-build-79539fbfbf4d/output/x86_64-apple-darwin/SHA256SUMS.part
2152f9083d8ca9bed5d660efc16b56c55eca6b62eccd91ac9ce467e3b3dfb89070  guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin-unsigned.tar.gz
22beeec3710916ee69af502853633b3fa1b626a7216f9990fcab8a3d4b18c9d036  guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin-unsigned.zip
23ffa4bfdb3a7f01af30b70abca8851743f0e6f50cb40e8370ff413304b5e1ae43  guix-build-79539fbfbf4d/output/x86_64-apple-darwin/bitcoin-79539fbfbf4d-x86_64-apple-darwin.tar.gz
24e9464eeedb6ad6063f418ef111268108af4e8a19e451ae5f003c4c73ce275a68  guix-build-79539fbfbf4d/output/x86_64-linux-gnu/SHA256SUMS.part
25747d76fea9a7eb954b046013f2ec3bffeee2744c38b08ece2ce2a21dfe72fa10  guix-build-79539fbfbf4d/output/x86_64-linux-gnu/bitcoin-79539fbfbf4d-x86_64-linux-gnu-debug.tar.gz
26c4cc213133bdb5f30b70464f229985186827968caa83d0559b6bd99abeb43d48  guix-build-79539fbfbf4d/output/x86_64-linux-gnu/bitcoin-79539fbfbf4d-x86_64-linux-gnu.tar.gz
274c74a51e65bb9413bb8ce0e01330c4a1c5d5a058644d139826310aef39caeddd  guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/SHA256SUMS.part
286cd37121ba0a8d4c01adb2ba7f87fc9cd62ad4d3b62b39ca026074c1ec28d81f  guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-debug.zip
29ccb1f4b0da302500832a3cb1aa449f28596c15020456d48fe0d03ba6508aaac2  guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-setup-unsigned.exe
30e39de2108b37e3d817c5e24d59c24c1531e281adc437fe29e5c9fa993ba7731b  guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64-unsigned.tar.gz
3158104f17ae951e0c72aed5fa413c305807c09bb7dd293724f57c26ff70553eb0  guix-build-79539fbfbf4d/output/x86_64-w64-mingw32/bitcoin-79539fbfbf4d-win64.zip

achow101 commented at 5:01 pm on October 31, 2023: member

ACK 79539fbfbf4d09a8b4861ddcba5b194297bc1b65

DrahtBot requested review from darosior on Oct 31, 2023

DrahtBot requested review from laanwj on Oct 31, 2023

DrahtBot requested review from hebasto on Oct 31, 2023

fanquake merged this on Oct 31, 2023

fanquake closed this on Oct 31, 2023

fanquake deleted the branch on Oct 31, 2023

fanquake commented at 5:10 pm on October 31, 2023: member

Added to #28754 for backporting to 26.x.

fanquake removed the label Needs backport (26.x) on Oct 31, 2023

fanquake referenced this in commit 05e8874554 on Oct 31, 2023

fanquake referenced this in commit 67b2512560 on Nov 1, 2023

bitcoin locked this on Oct 30, 2024

guix: update signapple to latest master #28759

Code Coverage

Reviews

Conflicts